MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/test/base/in_process_browser_test.h

Index: chrome/test/base/in_process_browser_test.h
diff --git a/chrome/test/base/in_process_browser_test.h b/chrome/test/base/in_process_browser_test.h
index d7bb9d152f7f18488643d68fefbd73aca6c54be6..b3c7c009c467c342c82f4d1e66043ba26b65bf7d 100644
--- a/chrome/test/base/in_process_browser_test.h
+++ b/chrome/test/base/in_process_browser_test.h
@@ -18,6 +18,10 @@
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/page_transition_types.h"
 
+#if defined(OS_MACOSX)
+#include "ui/base/test/scoped_fake_full_keyboard_access.h"
+#endif
+
 namespace base {
 
 class CommandLine;
@@ -264,6 +268,12 @@ class InProcessBrowserTest : public content::BrowserTestBase {
 #if defined(OS_MACOSX)
   base::mac::ScopedNSAutoreleasePool* autorelease_pool_;
   std::unique_ptr<ScopedBundleSwizzlerMac> bundle_swizzler_;
+
+  // Enable fake full keyboard access by default, so that tests don't depend on

[msw, 2017/04/19 18:23:17]

This seems like a big change. Is it possible that some tests will want this,
while others won't? Call this out in the CL description?

[varkha, 2017/04/20 04:14:20]

This makes tests n Mac more consistent so I think this is a worthwhile change.
I'll update the CL description.

+  // system setting of the test machine. Also, this helps to make tests on Mac
+  // more consistent with other platforms, where most views are focusable by
+  // default.
+  ui::test::ScopedFakeFullKeyboardAccess faked_full_keyboard_access_;
 #endif  // OS_MACOSX
 
 #if defined(OS_WIN)