MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/browser/ui/BUILD.gn

Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 403f89cd3d8c13bc7e6309690669f3230a3153f5..cbe85006ee87afcc49f214fd1b7d5275fd49aa4f 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -1529,6 +1529,20 @@ split_static_library("ui") {
       "views/page_info/permission_selector_row.cc",
       "views/page_info/permission_selector_row.h",
       "views/page_info/permission_selector_row_observer.h",
+      "views/passwords/account_chooser_dialog_view.cc",
+      "views/passwords/account_chooser_dialog_view.h",
+      "views/passwords/auto_signin_first_run_dialog_view.cc",
+      "views/passwords/auto_signin_first_run_dialog_view.h",
+      "views/passwords/credentials_item_view.cc",
+      "views/passwords/credentials_item_view.h",
+      "views/passwords/credentials_selection_view.cc",
+      "views/passwords/credentials_selection_view.h",
+      "views/passwords/manage_password_items_view.cc",
+      "views/passwords/manage_password_items_view.h",
+      "views/passwords/manage_passwords_bubble_view.cc",
+      "views/passwords/manage_passwords_bubble_view.h",
+      "views/passwords/manage_passwords_icon_views.cc",

[tapted, 2017/04/19 23:56:29]

(let's try removing manage_passwords_icon_views.cc from the build on mac+cocoa -
this file should only be depended on by the location bar used by BrowserView,
not BrowserWindowController. It might get tripped up by references in the other
passwords files, but there might be a clean way to resolve that and it may hint
at bugs)

[varkha, 2017/04/20 04:14:20]

Done.

+      "views/passwords/manage_passwords_icon_views.h",
       "views/payments/credit_card_editor_view_controller.cc",
       "views/payments/credit_card_editor_view_controller.h",
       "views/payments/cvc_unmask_view_controller.cc",
@@ -1822,20 +1836,6 @@ split_static_library("ui") {
         "views/omnibox/omnibox_view_views.h",
         "views/outdated_upgrade_bubble_view.cc",
         "views/outdated_upgrade_bubble_view.h",
-        "views/passwords/account_chooser_dialog_view.cc",
-        "views/passwords/account_chooser_dialog_view.h",
-        "views/passwords/auto_signin_first_run_dialog_view.cc",
-        "views/passwords/auto_signin_first_run_dialog_view.h",
-        "views/passwords/credentials_item_view.cc",
-        "views/passwords/credentials_item_view.h",
-        "views/passwords/credentials_selection_view.cc",
-        "views/passwords/credentials_selection_view.h",
-        "views/passwords/manage_password_items_view.cc",
-        "views/passwords/manage_password_items_view.h",
-        "views/passwords/manage_passwords_bubble_view.cc",
-        "views/passwords/manage_passwords_bubble_view.h",
-        "views/passwords/manage_passwords_icon_views.cc",
-        "views/passwords/manage_passwords_icon_views.h",
         "views/permission_bubble/chooser_bubble_ui_view.cc",
         "views/permission_bubble/chooser_bubble_ui_view.h",
         "views/permission_bubble/permission_prompt_impl_views.cc",
@@ -2886,8 +2886,8 @@ split_static_library("ui") {
         "cocoa/passwords/confirmation_password_saved_view_controller.mm",
         "cocoa/passwords/credential_item_button.h",
         "cocoa/passwords/credential_item_button.mm",
-        "cocoa/passwords/credentials_selection_view.h",
-        "cocoa/passwords/credentials_selection_view.mm",
+        "cocoa/passwords/credentials_selection_view_cocoa.h",
+        "cocoa/passwords/credentials_selection_view_cocoa.mm",
         "cocoa/passwords/manage_passwords_view_controller.h",
         "cocoa/passwords/manage_passwords_view_controller.mm",
         "cocoa/passwords/password_item_views.h",