chrome/browser/ui/views/passwords/credentials_selection_view_views.h - Issue 2808823002: MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/passwords/credentials_selection_view_views.h

Issue 2808823002: MacViews: Allows the toolkit-views Manage Passwords Dialog to be used (Closed)

Patch Set: MacViews: Allows the toolkit-views Manage Passwords Dialog to be used Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc ('K') | « chrome/browser/ui/views/passwords/credentials_selection_view.cc ('k') | chrome/browser/ui/views/passwords/credentials_selection_view_views.cc » ('j') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_CREDENTIALS_SELECTION_VIEW_H_	4 #ifndef CHROME_BROWSER_UI_VIEWS_PASSWORDS_CREDENTIALS_SELECTION_VIEW_VIEWS_H_
	tapted 2017/04/11 07:48:58 I think this rename was due to a duplicate object I think this rename was due to a duplicate object file - usually I try to rename the Cocoa file instead, since that's the one that may eventually be simply deleted, so a confusing name there doesn't matter as much. [edit: ah, I see you asked this in the submit message :)] varkha 2017/04/12 01:57:28 Done. Show quoted text On 2017/04/11 07:48:58, tapted wrote: > I think this rename was due to a duplicate object file - usually I try to rename > the Cocoa file instead, since that's the one that may eventually be simply > deleted, so a confusing name there doesn't matter as much. > > [edit: ah, I see you asked this in the submit message :)] Done.
5 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_CREDENTIALS_SELECTION_VIEW_H_	5 #define CHROME_BROWSER_UI_VIEWS_PASSWORDS_CREDENTIALS_SELECTION_VIEW_VIEWS_H_

6	6

7 #include <memory>	7 #include <memory>

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/macros.h"	10 #include "base/macros.h"

11 #include "components/autofill/core/common/password_form.h"	11 #include "components/autofill/core/common/password_form.h"

12 #include "ui/views/view.h"	12 #include "ui/views/view.h"

13	13

14 namespace views {	14 namespace views {

15 class Combobox;	15 class Combobox;

(...skipping 23 matching lines...) Expand all Loading...
39 std::unique_ptr<views::Combobox> combobox_;	39 std::unique_ptr<views::Combobox> combobox_;

40 std::unique_ptr<ui::SimpleComboboxModel> combobox_model_;	40 std::unique_ptr<ui::SimpleComboboxModel> combobox_model_;

41 int default_index_;	41 int default_index_;

42 bool is_default_best_match_;	42 bool is_default_best_match_;

43 bool is_default_preferred_;	43 bool is_default_preferred_;

44 bool action_reported_;	44 bool action_reported_;

45	45

46 DISALLOW_COPY_AND_ASSIGN(CredentialsSelectionView);	46 DISALLOW_COPY_AND_ASSIGN(CredentialsSelectionView);

47 };	47 };

48	48

49 #endif // CHROME_BROWSER_UI_VIEWS_PASSWORDS_CREDENTIALS_SELECTION_VIEW_H_	49 #endif // CHROME_BROWSER_UI_VIEWS_PASSWORDS_CREDENTIALS_SELECTION_VIEW_VIEWS_H_

OLD	NEW