MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/common/features.gni")
@@ skipping 509 matching lines @@
     }
 
     if (toolkit_views) {
       sources += [
         "../browser/ui/views/menu_controller_interactive_uitest.cc",
         "../browser/ui/views/menu_item_view_interactive_uitest.cc",
         "../browser/ui/views/menu_model_adapter_test.cc",
         "../browser/ui/views/menu_test_base.cc",
         "../browser/ui/views/menu_test_base.h",
         "../browser/ui/views/menu_view_drag_and_drop_test.cc",
+        "../browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc",
         "../browser/ui/views/status_icons/status_tray_state_changer_interactive_uitest_win.cc",
         "//ui/views/corewm/desktop_capture_controller_unittest.cc",
         "//ui/views/widget/desktop_aura/desktop_window_tree_host_x11_interactive_uitest.cc",
         "//ui/views/widget/desktop_aura/x11_topmost_window_finder_interactive_uitest.cc",
         "//ui/views/widget/widget_interactive_uitest.cc",
         "base/view_event_test_base.cc",
         "base/view_event_test_base.h",
       ]
       deps += [
         "//ui/views",
@@ skipping 11 matching lines @@
           "../browser/ui/views/constrained_window_views_browsertest.cc",
           "../browser/ui/views/extensions/extension_dialog_interactive_uitest.cc",
           "../browser/ui/views/find_bar_views_interactive_uitest.cc",
           "../browser/ui/views/frame/browser_view_focus_uitest.cc",
           "../browser/ui/views/frame/browser_view_interactive_uitest.cc",
           "../browser/ui/views/keyboard_access_browsertest.cc",
           "../browser/ui/views/location_bar/location_icon_view_interactive_uitest.cc",
           "../browser/ui/views/location_bar/star_view_browsertest.cc",
           "../browser/ui/views/omnibox/omnibox_view_views_browsertest.cc",
           "../browser/ui/views/page_info/page_info_bubble_view_interactive_uitest.cc",
-          "../browser/ui/views/passwords/manage_passwords_bubble_view_interactive_uitest.cc",
           "../browser/ui/views/passwords/manage_passwords_icon_view_interactive_uitest.cc",

[msw, 2017/04/19 18:23:17]

Should this also be supported for mac views?

[tapted, 2017/04/19 23:56:29]

not yet for this one, since this is the icon used in the location bar, which is
still uses Cocoa-based decorations under MacViews. But thanks for pointing this
out! We should try removing manage_passwords_icon_views.cc from the build - it
shouldn't be necessary yet.

           "../browser/ui/views/ssl_client_certificate_selector_browsertest.cc",
           "../browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc",
           "../browser/ui/views/tabs/tab_drag_controller_interactive_uitest.h",
           "../browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc",
           "../browser/ui/views/toolbar/toolbar_button_interactive_uitest.cc",
           "../browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc",
           "../browser/ui/views/translate/translate_bubble_test_utils_views.cc",
           "base/interactive_test_utils_views.cc",
         ]
       }
@@ skipping 4668 matching lines @@
 }
 
 if (is_win) {
   loadable_module("conflicts_dll") {
     testonly = true
     sources = [
       "conflicts/conflicts_dll.cc",
     ]
   }
 }