chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.mm - Issue 2808823002: MacViews: Allows the toolkit-views Manage Passwords Dialog to be used

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.mm

Issue 2808823002: MacViews: Allows the toolkit-views Manage Passwords Dialog to be used (Closed)

Patch Set: MacViews: Allows the toolkit-views Manage Passwords Dialog to be used (tests compile) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.h ('k') | chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h » ('j') | chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_views.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "chrome/browser/ui/cocoa/passwords/credentials_selection_view.h"	5 #import "chrome/browser/ui/cocoa/passwords/credentials_selection_view_cocoa.h"
	tapted 2017/04/12 05:08:42 it's worth mentioning in the CL description body t it's worth mentioning in the CL description body that this rename is occurring (and why) varkha 2017/04/12 09:16:43 Done. Show quoted text On 2017/04/12 05:08:42, tapted wrote: > it's worth mentioning in the CL description body that this rename is occurring > (and why) Done.
6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #import "chrome/browser/ui/cocoa/bubble_combobox.h"	9 #import "chrome/browser/ui/cocoa/bubble_combobox.h"

10 #include "chrome/browser/ui/cocoa/chrome_style.h"	10 #include "chrome/browser/ui/cocoa/chrome_style.h"

11 #import "chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h"	11 #import "chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h"

12 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"	12 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"

13 #include "ui/base/models/simple_combobox_model.h"	13 #include "ui/base/models/simple_combobox_model.h"

14	14

15 namespace {	15 namespace {

(...skipping 92 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
108 return self;	108 return self;

109 }	109 }

110	110

111 - (const autofill::PasswordForm*)getSelectedCredentials {	111 - (const autofill::PasswordForm*)getSelectedCredentials {

112 int selected_index = [usernamePopUpButton_ indexOfSelectedItem];	112 int selected_index = [usernamePopUpButton_ indexOfSelectedItem];

113 CHECK(selected_index >= 0);	113 CHECK(selected_index >= 0);

114 return &model_->local_credentials()[selected_index];	114 return &model_->local_credentials()[selected_index];

115 }	115 }

116	116

117 @end	117 @end

OLD	NEW