Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: test/mjsunit/harmony/regexp-property-special.js

Issue 2808803002: [regexp] implement \p{Other_ID_Start} and \p{Other_ID_Continue}. (Closed)
Patch Set: small fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/regexp/regexp-parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/regexp-property-special.js
diff --git a/test/mjsunit/harmony/regexp-property-special.js b/test/mjsunit/harmony/regexp-property-special.js
index 204b77fb231750b5c6bb72dafe07a79360ea1e5e..60ab363dcea9b79e951ff94e3ae30d9b38905594 100644
--- a/test/mjsunit/harmony/regexp-property-special.js
+++ b/test/mjsunit/harmony/regexp-property-special.js
@@ -44,8 +44,14 @@ t(/\P{Assigned}+/u, "\ufdd0");
t(/\P{Assigned}+/u, "\u{fffff}");
f(/\P{Assigned}/u, "");
-t(/[^\P{Assigned}]+/u, "123");
-f(/[\P{Assigned}]+/u, "🄰🄱🄲");
-f(/[^\P{Assigned}]+/u, "\ufdd0");
-t(/[\P{Assigned}]+/u, "\u{fffff}");
-f(/[\P{Assigned}]/u, "");
+f(/[^\u1234\p{ASCII}]+/u, "\u1234");
+t(/[x\P{ASCII}]+/u, "x");
+t(/[\u1234\p{ASCII}]+/u, "\u1234");
+
+t(/^\p{Other_ID_Start}+$/u, "\u1885\u1886\u2118\u212e\u309b\u309c");
+f(/\P{OIDS}/u, "\u1885\u1886\u2118\u212e\u309b\u309c");
+f(/^[x\P{Other_ID_Start}]+$/u, "\u1885\u1886\u2118\u212e\u309b\u309cx");
+t(/[x\P{OIDS}]/u, "\u1885\u1886\u2118\u212e\u309b\u309cx");
jgruber 2017/04/10 13:46:50 Is this test missing anchors? Otherwise it will ma
Yang 2017/04/11 09:00:37 Good catch. Fixed.
+
+t(/^\p{Other_ID_Continue}+$/u, "\u00b7\u0387\u1369\u1371\u19da");
jgruber 2017/04/10 13:46:50 We could include 0x136A, 0x136B, 0x136C, 0x136D,
Yang 2017/04/11 09:00:37 Done.
+f(/\P{OIDC}/u, "\u00b7\u0387\u1369\u1371\u19da");
« no previous file with comments | « src/regexp/regexp-parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698