Issue 2808763008: Never erase parameter types in the JIT.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808763008: Never erase parameter types in the JIT. (Closed)

Created:
3 years, 8 months ago by rmacnak

Modified:
3 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Never erase parameter types in the JIT. Even in unchecked mode with mirrors disabled, we need to be able to forward parameter types to lazily generated implicit closure functions. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/39040a8a1500e0683681afd6f361b4f65e5cfa5f

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -11 lines)			Patch
	M	runtime/vm/program_visitor.cc	View	1	4 chunks	+7 lines, -11 lines	0 comments	Download

Total messages: 6 (2 generated)

rmacnak

On 2017/04/12 22:26:52, siva wrote: > lgtm Also remove visitor assert that is only true ...

3 years, 8 months ago (2017-04-12 22:28:54 UTC) #4

rmacnak

3 years, 8 months ago (2017-04-12 22:40:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
39040a8a1500e0683681afd6f361b4f65e5cfa5f (presubmit successful).