Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2808763005: Extract OrderedTypeSetBuilderBase from OrderedTypeSetBuilder (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract OrderedTypeSetBuilderBase from OrderedTypeSetBuilder - to make it reusable for kernel based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/5ccf530f62a23e3ac04ba440bc87bd1f42d53aea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -108 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/resolution_types.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 12 chunks +96 lines, -80 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/class_set_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-12 10:27:34 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-12 18:00:02 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-18 07:29:48 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5ccf530f62a23e3ac04ba440bc87bd1f42d53aea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698