Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

Issue 2808753003: Carve out an exception for embedded credentials in XHR. (Closed)
Patch Set: Rebaseline. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/remember-bad-password-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
index c76c035d6a8a55018be956d5d2a2b08e98bcf51d..fee40156b61d366ca25a0262b3b13c9b62e2951e 100644
--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
@@ -833,7 +833,10 @@ ResourceRequestBlockedReason FrameFetchContext::CanRequestInternal(
if (RuntimeEnabledFeatures::blockLegacySubresourcesEnabled())
return ResourceRequestBlockedReason::kOrigin;
}
- if (!url.User().IsEmpty() || !url.Pass().IsEmpty()) {
+
+ if ((!url.User().IsEmpty() || !url.Pass().IsEmpty()) &&
+ resource_request.GetRequestContext() !=
+ WebURLRequest::kRequestContextXMLHttpRequest) {
Deprecation::CountDeprecation(
GetFrame()->GetDocument(),
UseCounter::kRequestedSubresourceWithEmbeddedCredentials);
« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/remember-bad-password-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698