Issue 2808683003: Remove most direct uses of 'backend' and 'compiler' in GraphBuilder.

Issue 2808683003: Remove most direct uses of 'backend' and 'compiler' in GraphBuilder. (Closed)

Created:
3 years, 8 months ago by Johnni Winther

Modified:
3 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove most direct uses of 'backend' and 'compiler' in GraphBuilder. This is a step towards using data objects instead of directly accessing JavaScriptBackend and Compiler. This is needed to support an element model switch between resolution and codegen. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/364ecead7e3f6fcaa931cd965b03d29309c36d32

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+125 lines, -112 lines)			Patch
M	pkg/compiler/lib/src/native/ssa.dart	View	4 chunks	+3 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	51 chunks	+62 lines, -78 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder_kernel.dart	View	20 chunks	+24 lines, -28 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/graph_builder.dart	View	4 chunks	+36 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Emily Fortuna

lgtm. I'm going to have a "fun" time merging this with my change. :-D

3 years, 8 months ago (2017-04-10 19:29:55 UTC) #3

Johnni Winther

3 years, 8 months ago (2017-04-11 07:50:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
364ecead7e3f6fcaa931cd965b03d29309c36d32 (presubmit successful).