Chromium Code Reviews Chromium Code Reviews
Issue 2808663002:
Add base and bonus scores to site-engagement WebUI. (Closed)
| OLD | NEW |
|---|---|
| 1 <!doctype html> | 1 <!doctype html> |
| 2 <head> | 2 <head> |
| 3 <title>Site Engagement</title> | 3 <title>Site Engagement</title> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> | 5 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| 6 <script src="chrome://resources/js/util.js"></script> | 6 <script src="chrome://resources/js/util.js"></script> |
| 7 <script src="chrome://site-engagement/site_engagement.js"></script> | 7 <script src="chrome://site-engagement/site_engagement.js"></script> |
| 8 <style> | 8 <style> |
| 9 body { | 9 body { |
| 10 font-family: 'Roboto', 'Noto', sans-serif; | 10 font-family: 'Roboto', 'Noto', sans-serif; |
| 11 font-size: 14px; | 11 font-size: 14px; |
| 12 } | 12 } |
| 13 | 13 |
| 14 table { | 14 table { |
| 15 border-collapse: collapse; | 15 border-collapse: collapse; |
| 16 } | 16 } |
| 17 | 17 |
| 18 table td, | 18 table td, |
| 19 table th { | 19 table th { |
| 20 border: 1px solid #777; | 20 border: 1px solid #777; |
| 21 padding-left: 4px; | 21 padding-left: 4px; |
| 22 padding-right: 4px; | 22 padding-right: 4px; |
| 23 } | 23 } |
| 24 | 24 |
| 25 table th { | 25 table th { |
| 26 background: rgb(224, 236, 255); | 26 background: rgb(224, 236, 255); |
| 27 cursor: pointer; | 27 cursor: pointer; |
| 28 padding-bottom: 4px; | 28 padding-bottom: 4px; |
| 29 padding-top: 4px; | 29 padding-top: 4px; |
| 30 white-space: nowrap; | 30 white-space: nowrap; |
|
calamity
2017/04/11 01:16:56
visual nit: Set a min-width here to prevent the ta
Wez
2017/04/12 23:49:48
Done. Is there a better way to do that than just h
calamity
2017/04/13 03:34:36
You can make the ::after element position: absolut
Wez
2017/04/18 06:40:31
Done.
| |
| 31 } | 31 } |
| 32 | 32 |
| 33 .engagement-bar { | 33 .engagement-bar { |
| 34 background-color: black; | 34 background-color: black; |
| 35 height: 2px; | 35 height: 2px; |
| 36 } | 36 } |
| 37 | 37 |
| 38 .engagement-bar-cell { | 38 .engagement-bar-cell { |
| 39 border: none; | 39 border: none; |
| 40 } | 40 } |
| 41 | 41 |
| 42 .origin-cell { | 42 .origin-cell { |
| 43 background-color: rgba(230, 230, 230, 0.5); | 43 background-color: rgba(230, 230, 230, 0.5); |
| 44 min-width: 500px; | 44 min-width: 500px; |
| 45 } | 45 } |
| 46 | 46 |
| 47 .score-cell { | 47 .base-score-cell, |
| 48 .bonus-score-cell, | |
| 49 .total-score-cell { | |
| 48 background-color: rgba(230, 230, 230, 0.5); | 50 background-color: rgba(230, 230, 230, 0.5); |
| 49 text-align: right; | 51 text-align: right; |
| 50 } | 52 } |
| 51 | 53 |
| 52 .score-input { | 54 .base-score-input { |
| 53 border: 1px solid #ccc; | 55 border: 1px solid #ccc; |
| 54 border-radius: 2px; | 56 border-radius: 2px; |
| 55 text-align: right; | 57 text-align: right; |
| 56 width: 70px; | 58 width: 70px; |
| 57 } | 59 } |
| 58 | 60 |
| 59 .score-input:focus { | 61 .score-input:focus { |
|
calamity
2017/04/11 01:16:56
base-score-input?
Wez
2017/04/12 23:49:48
Done.
| |
| 60 border: 1px solid rgb(143, 185, 252); | 62 border: 1px solid rgb(143, 185, 252); |
| 61 box-shadow: 0 0 2px rgb(113, 158, 206); | 63 box-shadow: 0 0 2px rgb(113, 158, 206); |
| 62 outline: none; | 64 outline: none; |
| 63 } | 65 } |
| 64 | 66 |
| 65 table tr:hover { | 67 table tr:hover { |
| 66 background: rgb(255, 255, 187); | 68 background: rgb(255, 255, 187); |
| 67 } | 69 } |
| 68 | 70 |
| 69 th.sort-column::after { | 71 th.sort-column::after { |
| 70 content: '▲'; | 72 content: '▲'; |
| 71 } | 73 } |
| 72 | 74 |
| 73 th[sort-reverse].sort-column::after { | 75 th[sort-reverse].sort-column::after { |
| 74 content: '▼'; | 76 content: '▼'; |
| 75 } | 77 } |
| 76 </style> | 78 </style> |
| 77 </head> | 79 </head> |
| 78 <body> | 80 <body> |
| 79 <h1>Site Engagement</h1> | 81 <h1>Site Engagement</h1> |
| 80 <table> | 82 <table> |
| 81 <thead> | 83 <thead> |
| 82 <tr id="engagement-table-header"> | 84 <tr id="engagement-table-header"> |
| 83 <th sort-key="origin"> | 85 <th sort-key="origin"> |
| 84 Origin | 86 Origin |
| 85 </th> | 87 </th> |
| 88 <th sort-key="base_score" class="sort-column" sort-reverse> | |
| 89 Base | |
| 90 </th> | |
| 91 <th sort-key="bonus_score" class="sort-column" sort-reverse> | |
| 92 Bonus | |
| 93 </th> | |
| 86 <th sort-key="total_score" class="sort-column" sort-reverse> | 94 <th sort-key="total_score" class="sort-column" sort-reverse> |
| 87 Points | 95 Total |
| 88 </th> | 96 </th> |
| 89 </tr> | 97 </tr> |
| 90 </thead> | 98 </thead> |
| 91 <tbody id="engagement-table-body"> | 99 <tbody id="engagement-table-body"> |
| 92 </tbody> | 100 </tbody> |
| 93 </table> | 101 </table> |
| 94 </body> | 102 </body> |
| 95 </html> | 103 </html> |
| OLD | NEW |
