Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8311)

Unified Diff: components/payments/content/payment_request_state_unittest.cc

Issue 2808633002: [Payments] Move PaymentResponse logic to PaymentResponseHelper. (Closed)
Patch Set: Addressed Mathp's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/payments/content/payment_request_state_unittest.cc
diff --git a/components/payments/content/payment_request_state_unittest.cc b/components/payments/content/payment_request_state_unittest.cc
index 672c9f5a70764c175bc4dcb1e02dbe75c639f3cc..3d2c8c42f6a8f10c777853463adc42b9152c42e9 100644
--- a/components/payments/content/payment_request_state_unittest.cc
+++ b/components/payments/content/payment_request_state_unittest.cc
@@ -297,6 +297,8 @@ TEST_F(PaymentRequestStateTest, ReadyToPay_ContactInfo) {
EXPECT_TRUE(state()->is_ready_to_pay());
}
+// TODO(crbug.com/710160): Move the PaymentResponse tests to
+// payment_response_helper_unittest.cc.
// Test generating a PaymentResponse.
TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_SupportedMethod) {
// Default options (no shipping, no contact info).
@@ -328,6 +330,8 @@ TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_SupportedMethod) {
response()->stringified_details);
}
+// TODO(crbug.com/710160): Move the PaymentResponse tests to
+// payment_response_helper_unittest.cc.
// Test generating a PaymentResponse when the method is specified through
// "basic-card".
TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_BasicCard) {
@@ -365,6 +369,8 @@ TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_BasicCard) {
response()->stringified_details);
}
+// TODO(crbug.com/710160): Move the PaymentResponse tests to
+// payment_response_helper_unittest.cc.
// Tests the the generated PaymentResponse has the correct values for the
// shipping address.
TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_ShippingAddress) {
@@ -399,6 +405,8 @@ TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_ShippingAddress) {
EXPECT_EQ("16502111111", response()->shipping_address->phone);
}
+// TODO(crbug.com/710160): Move the PaymentResponse tests to
+// payment_response_helper_unittest.cc.
// Tests the the generated PaymentResponse has the correct values for the
// contact details when all values are requested.
TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_ContactDetails_All) {
@@ -418,6 +426,8 @@ TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_ContactDetails_All) {
EXPECT_EQ("johndoe@hades.com", response()->payer_email.value());
}
+// TODO(crbug.com/710160): Move the PaymentResponse tests to
+// payment_response_helper_unittest.cc.
// Tests the the generated PaymentResponse has the correct values for the
// contact details when all values are requested.
TEST_F(PaymentRequestStateTest, GeneratePaymentResponse_ContactDetails_Some) {

Powered by Google App Engine
This is Rietveld 408576698