[Payments] Move PaymentResponse logic to PaymentResponseHelper.

components/payments/content/payment_request_state.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/payments/content/payment_request_state.h"
 
 #include <set>
 
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
@@ skipping 21 matching lines @@
       personal_data_manager_(personal_data_manager),
       selected_shipping_profile_(nullptr),
       selected_contact_profile_(nullptr),
       selected_instrument_(nullptr),
       payment_request_delegate_(payment_request_delegate) {
   PopulateProfileCache();
   SetDefaultProfileSelections();
 }
 PaymentRequestState::~PaymentRequestState() {}
 
+void PaymentRequestState::OnPaymentResponseReady(
+    mojom::PaymentResponsePtr payment_response) {
+  delegate_->OnPaymentResponseAvailable(std::move(payment_response));
+}
+
 bool PaymentRequestState::CanMakePayment() const {
   for (const std::unique_ptr<PaymentInstrument>& instrument :
        available_instruments_) {
     if (instrument.get()->IsValid() &&
         spec_->supported_card_networks_set().count(
             instrument.get()->method_name())) {
       return true;
     }
   }
   return false;
 }
 
 void PaymentRequestState::AddObserver(Observer* observer) {
   CHECK(observer);
   observers_.AddObserver(observer);
 }
 
 void PaymentRequestState::RemoveObserver(Observer* observer) {
   observers_.RemoveObserver(observer);
 }
 
-// TODO(sebsg): Move this to the PaymentResponseHelper.
-void PaymentRequestState::OnInstrumentDetailsReady(
-    const std::string& method_name,
-    const std::string& stringified_details) {
-  mojom::PaymentResponsePtr payment_response = mojom::PaymentResponse::New();
-
-  // Make sure that we return the method name that the merchant specified for
-  // this instrument: cards can be either specified through their name (e.g.,
-  // "visa") or through basic-card's supportedNetworks.
-  payment_response->method_name =
-      spec_->IsMethodSupportedThroughBasicCard(method_name)
-          ? kBasicCardMethodName
-          : method_name;
-  payment_response->stringified_details = stringified_details;
-
-  // Shipping Address section
-  if (spec_->request_shipping()) {
-    DCHECK(selected_shipping_profile_);
-    payment_response->shipping_address =
-        PaymentResponseHelper::GetMojomPaymentAddressFromAutofillProfile(
-            selected_shipping_profile_, app_locale_);
-
-    DCHECK(spec_->selected_shipping_option());
-    payment_response->shipping_option = spec_->selected_shipping_option()->id;
-  }
-
-  // Contact Details section.
-  if (spec_->request_payer_name()) {
-    DCHECK(selected_contact_profile_);
-    payment_response->payer_name =
-        base::UTF16ToUTF8(selected_contact_profile_->GetInfo(
-            autofill::AutofillType(autofill::NAME_FULL), app_locale_));
-  }
-  if (spec_->request_payer_email()) {
-    DCHECK(selected_contact_profile_);
-    payment_response->payer_email = base::UTF16ToUTF8(
-        selected_contact_profile_->GetRawInfo(autofill::EMAIL_ADDRESS));
-  }
-  if (spec_->request_payer_phone()) {
-    DCHECK(selected_contact_profile_);
-    // TODO(crbug.com/705945): Format phone number according to spec.
-    payment_response->payer_phone =
-        base::UTF16ToUTF8(selected_contact_profile_->GetRawInfo(
-            autofill::PHONE_HOME_WHOLE_NUMBER));
-  }
-
-  delegate_->OnPaymentResponseAvailable(std::move(payment_response));
-}
-
 void PaymentRequestState::GeneratePaymentResponse() {
   DCHECK(is_ready_to_pay());
-  // Fetch the instrument details, will call back into
-  // PaymentRequest::OnInstrumentDetailsReady.
-  selected_instrument_->InvokePaymentApp(this);
+
+  // Once the response is ready, will call back into OnPaymentResponseReady.
+  response_helper_.reset(

[Mathieu, 2017/04/10 00:03:22]

response_helper_ = base::MakeUnique...

[sebsg, 2017/04/10 20:48:24]

Done.

+      new PaymentResponseHelper(app_locale_, spec_, selected_shipping_profile_,

[Mathieu, 2017/04/10 00:03:22]

should probably pass the selected_instrument_ here as well and let the
PaymentResponseHelper call InvokePaymentApp?

[sebsg, 2017/04/10 20:48:24]

Done.

+                                selected_contact_profile_, this));
+  selected_instrument_->InvokePaymentApp(response_helper_.get());
 }
 
 void PaymentRequestState::SetSelectedShippingOption(
     const std::string& shipping_option_id) {
   // This will inform the merchant and will lead to them calling updateWith with
   // new PaymentDetails.
   delegate_->OnShippingOptionIdSelected(shipping_option_id);
 }
 
 void PaymentRequestState::SetSelectedShippingProfile(
@@ skipping 124 matching lines @@
 bool PaymentRequestState::ArePaymentOptionsSatisfied() {
   // TODO(mathp): Have a measure of shipping address completeness.
   if (spec_->request_shipping() && selected_shipping_profile_ == nullptr)
     return false;
 
   profile_util::PaymentsProfileComparator comparator(app_locale_, *spec_);
   return comparator.IsContactInfoComplete(selected_contact_profile_);
 }
 
 }  // namespace payments