Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2808623002: Add 4 integration tests for the analysis domain. (Closed)

Created:
3 years, 8 months ago by devoncarew
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 2

Messages

Total messages: 7 (2 generated)
devoncarew
This CL adds integration tests for analysis.getReachableSources, analysis.getLibraryDependencies, analysis.setGeneralSubscriptions, and analysis.setPriorityFiles. The first two don't ...
3 years, 8 months ago (2017-04-08 20:33:50 UTC) #2
scheglov
lgtm
3 years, 8 months ago (2017-04-08 20:50:40 UTC) #3
devoncarew
Committed patchset #2 (id:20001) manually as e572bf93ecea4105da268821c6329fbdf424f26c (presubmit successful).
3 years, 8 months ago (2017-04-09 03:56:04 UTC) #5
Brian Wilkerson
lgtm https://codereview.chromium.org/2808623002/diff/20001/pkg/analysis_server/test/integration/analysis/get_library_dependencies_test.dart File pkg/analysis_server/test/integration/analysis/get_library_dependencies_test.dart (right): https://codereview.chromium.org/2808623002/diff/20001/pkg/analysis_server/test/integration/analysis/get_library_dependencies_test.dart#newcode19 pkg/analysis_server/test/integration/analysis/get_library_dependencies_test.dart:19: @failingTest Does the test pass in the non-driver ...
3 years, 8 months ago (2017-04-09 16:36:05 UTC) #6
devoncarew
3 years, 8 months ago (2017-04-09 18:23:01 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2808623002/diff/20001/pkg/analysis_server/tes...
File
pkg/analysis_server/test/integration/analysis/get_library_dependencies_test.dart
(right):

https://codereview.chromium.org/2808623002/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/integration/analysis/get_library_dependencies_test.dart:19:
@failingTest
On 2017/04/09 16:36:05, Brian Wilkerson wrote:
> Does the test pass in the non-driver case?

Yes, I wrote the body of the test w/o the driver enabled - so the test is good -
then toggled it since that's what I wanted to be testing.

Powered by Google App Engine
This is Rietveld 408576698