Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2808553002: Revert of Update third_party/checkstyle to 7.6.1 (Closed)

Created:
3 years, 8 months ago by F
Modified:
3 years, 8 months ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update third_party/checkstyle to 7.6.1 (patchset #2 id:40001 of https://codereview.chromium.org/2799303003/ ) Reason for revert: Breaking trybots Original issue's description: > Update third_party/checkstyle to 7.6.1 > > This CL updates third_party/checkstyle to 7.6.1 so checkstyle would > work with Java 8 lambda features. > > BUG=703238 > > Review-Url: https://codereview.chromium.org/2799303003 > Cr-Commit-Position: refs/heads/master@{#462968} > Committed: https://chromium.googlesource.com/chromium/src/+/dbce02f63421f7d446d6ef317b456f6ae911f63b TBR=agrieve@chromium.org,nyquist@chromium.org,jbudorick@chromium.org,klobag@chromium.org,jbudorick@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703238

Patch Set 1 #

Patch Set 2 : proper revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -43 lines) Patch
M DEPS View 1 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/checkstyle/OWNERS View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/checkstyle/README.chromium View 1 2 chunks +4 lines, -14 lines 0 comments Download
A third_party/checkstyle/checkstyle-6.5-all.jar View Binary file 0 comments Download
D third_party/checkstyle/checkstyle-7.6.1-all.jar.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/checkstyle/checkstyle.py View 1 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
F
Created Revert of Update third_party/checkstyle to 7.6.1
3 years, 8 months ago (2017-04-07 20:13:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808553002/1
3 years, 8 months ago (2017-04-07 20:13:48 UTC) #3
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
3 years, 8 months ago (2017-04-07 20:19:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808553002/170001
3 years, 8 months ago (2017-04-07 20:25:02 UTC) #7
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
3 years, 8 months ago (2017-04-07 20:28:14 UTC) #9
Alexei Svitkine (slow)
3 years, 8 months ago (2017-04-07 22:28:49 UTC) #11
I was able to revert via https://codereview.chromium.org/2807753003

Did a local git revert on the original commit hash, then committed that locally,
uploaded to codereview and did a git cl land.

Powered by Google App Engine
This is Rietveld 408576698