chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 280853004: Use EventRouter::Get instead of ExtensionSystem::Get(browser_context)->event_router()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 280853004: Use EventRouter::Get instead of ExtensionSystem::Get(browser_context)->event_router() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/automation_internal/automation_util.cc ('K') | « chrome/browser/extensions/api/automation_internal/automation_util.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index 46f1d4eb64957875c077d05c03ed7ae80cfa661a..e117f172e3bb5f3df75544d9b9786e9aa7a5c670 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -1744,8 +1744,7 @@ void ExtensionDownloadsEventRouter::OnListenerRemoved(

return;

bool determiner_removed = (

details.event_name == downloads::OnDeterminingFilename::kEventName);

- extensions::EventRouter* router = extensions::ExtensionSystem::Get(profile_)->

- event_router();

+ EventRouter* router = EventRouter::Get(profile_);

bool any_listeners =

router->HasEventListener(downloads::OnChanged::kEventName) ||

router->HasEventListener(downloads::OnDeterminingFilename::kEventName);

@@ -1784,8 +1783,7 @@ void ExtensionDownloadsEventRouter::OnDownloadCreated(

if (download_item->IsTemporary())

return;

- extensions::EventRouter* router = extensions::ExtensionSystem::Get(profile_)->

- event_router();

+ EventRouter* router = EventRouter::Get(profile_);

// Avoid allocating a bunch of memory in DownloadItemToJSON if it isn't going

// to be used.

if (!router ||

@@ -1812,8 +1810,7 @@ void ExtensionDownloadsEventRouter::OnDownloadCreated(

void ExtensionDownloadsEventRouter::OnDownloadUpdated(

DownloadManager* manager, DownloadItem* download_item) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- extensions::EventRouter* router = extensions::ExtensionSystem::Get(profile_)->

- event_router();

+ EventRouter* router = EventRouter::Get(profile_);

ExtensionDownloadsEventRouterData* data =

ExtensionDownloadsEventRouterData::Get(download_item);

if (download_item->IsTemporary() ||