Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2970)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2808513002: [Payments] Add PaymentRequest checkout funnel UKMs. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
index 41176e4dd1e0c7b4d18e7d55d359b8799b9a0ba1..843622cc9117feead717a635970a473b62dbf983 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
@@ -45,7 +45,6 @@ import org.chromium.chrome.browser.tabmodel.TabModelObserver;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.tabmodel.TabModelSelectorObserver;
import org.chromium.components.payments.CurrencyFormatter;
-import org.chromium.components.payments.JourneyLogger;
import org.chromium.components.payments.PaymentValidator;
import org.chromium.components.url_formatter.UrlFormatter;
import org.chromium.content_public.browser.RenderFrameHost;
@@ -381,7 +380,7 @@ public class PaymentRequestImpl
mIsIncognito = activity != null && activity.getCurrentTabModel() != null
&& activity.getCurrentTabModel().isIncognito();
- mJourneyLogger = new JourneyLogger(mIsIncognito);
+ mJourneyLogger = new JourneyLogger(mIsIncognito, mWebContents.getLastCommittedUrl());
if (sCanMakePaymentQueries == null) sCanMakePaymentQueries = new ArrayMap<>();
@@ -600,6 +599,7 @@ public class PaymentRequestImpl
mDidRecordShowEvent = true;
mShouldRecordAbortReason = true;
recordSuccessFunnelHistograms("Shown");
+ mJourneyLogger.setEventOccurred(JourneyLogger.EVENT_SHOWN);
mJourneyLogger.setShowCalled();
onPayClicked(null /* selectedShippingAddress */, null /* selectedShippingOption */,
@@ -1199,6 +1199,7 @@ public class PaymentRequestImpl
Collections.unmodifiableMap(modifiers), this);
recordSuccessFunnelHistograms("PayClicked");
+ mJourneyLogger.setEventOccurred(JourneyLogger.EVENT_PAY_CLICKED);
return !(instrument instanceof AutofillPaymentInstrument);
}
@@ -1512,6 +1513,7 @@ public class PaymentRequestImpl
if (mShouldSkipShowingPaymentRequestUi) mUI.showProcessingMessageAfterUiSkip();
recordSuccessFunnelHistograms("ReceivedInstrumentDetails");
+ mJourneyLogger.setEventOccurred(JourneyLogger.EVENT_RECEIVED_INSTRUMENT_DETAILS);
mPaymentResponseHelper.onInstrumentDetailsReceived(methodName, stringifiedDetails);
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698