chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2808513002: [Payments] Add PaymentRequest checkout funnel UKMs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2808513002: [Payments] Add PaymentRequest checkout funnel UKMs. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/JourneyLogger.java ('k') | chrome/android/java_sources.gni » ('j') | chrome/browser/android/chrome_jni_registrar.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index 41176e4dd1e0c7b4d18e7d55d359b8799b9a0ba1..0098127aed47255cd2558d10a5bd69107f54b48b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -45,7 +45,6 @@ import org.chromium.chrome.browser.tabmodel.TabModelObserver;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

import org.chromium.chrome.browser.tabmodel.TabModelSelectorObserver;

import org.chromium.components.payments.CurrencyFormatter;

-import org.chromium.components.payments.JourneyLogger;

import org.chromium.components.payments.PaymentValidator;

import org.chromium.components.url_formatter.UrlFormatter;

import org.chromium.content_public.browser.RenderFrameHost;

@@ -381,7 +380,7 @@ public class PaymentRequestImpl

mIsIncognito = activity != null && activity.getCurrentTabModel() != null

&& activity.getCurrentTabModel().isIncognito();

- mJourneyLogger = new JourneyLogger(mIsIncognito);

+ mJourneyLogger = new JourneyLogger(mIsIncognito, mOriginForDisplay);

Mathieu 2017/04/10 01:03:01 I feel like we are tying two things that shouldn't

sebsg 2017/04/10 15:30:28 Done.

if (sCanMakePaymentQueries == null) sCanMakePaymentQueries = new ArrayMap<>();