[Payments] Add PaymentRequest checkout funnel UKMs.

components/ukm/ukm_service.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_UKM_UKM_SERVICE_H_
 #define COMPONENTS_UKM_UKM_SERVICE_H_
 
 #include <stddef.h>
 #include <memory>
 #include <vector>
@@ skipping 11 matching lines @@
 
 class PluginInfoMessageFilter;
 class PrefRegistrySimple;
 class PrefService;
 class UkmPageLoadMetricsObserver;
 
 namespace autofill {
 class AutofillMetrics;
 }  // namespace autofill
 
+namespace payments {
+class JourneyLogger;
+}  // namespace payments
+
 namespace metrics {
 class MetricsServiceClient;
 }
 
 namespace ukm {
 
 class UkmEntry;
 class UkmEntryBuilder;
 class UkmSource;
 
@@ skipping 61 matching lines @@
       const {
     return sources_;
   }
 
   const std::vector<std::unique_ptr<UkmEntry>>& entries_for_testing() const {
     return entries_;
   }
 
  private:
   friend autofill::AutofillMetrics;
+  friend payments::JourneyLogger;

[please use gerrit instead, 2017/04/10 19:20:03]

Why are you reaching into the privates of ukm service?

[sebsg, 2017/04/10 19:49:53]

Love your wording :P

I need to be friends to be able to access GetEntryBuilder. All the UKM users are
friends for now, this is intentional, see line 128-133 in this file for more
info.

   friend PluginInfoMessageFilter;
   friend UkmPageLoadMetricsObserver;
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, AddEntryOnlyWithNonEmptyMetrics);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, EntryBuilderAndSerialization);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest,
                            LogsUploadedOnlyWhenHavingSourcesOrEntries);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, MetricsProviderTest);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, PersistAndPurge);
   FRIEND_TEST_ALL_PREFIXES(UkmServiceTest, WhitelistEntryTest);
 
@@ skipping 73 matching lines @@
   // Weak pointers factory used to post task on different threads. All weak
   // pointers managed by this factory have the same lifetime as UkmService.
   base::WeakPtrFactory<UkmService> self_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(UkmService);
 };
 
 }  // namespace ukm
 
 #endif  // COMPONENTS_UKM_UKM_SERVICE_H_