Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2808443002: Switch to Fasta in "golden" tests of closure conversion (Closed)

Created:
3 years, 8 months ago by Dmitry Stefantsov
Modified:
3 years, 8 months ago
Reviewers:
karlklose, ahe
CC:
reviews_dartlang.org, Kevin Millikin (Google)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch to Fasta in "golden" tests of closure conversion R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/cd501b2db3b23a57d0fb66960b3cd4d85069cd02

Patch Set 1 #

Patch Set 2 : Use testing framework from Fasta package in Closure Conversion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -350 lines) Patch
D pkg/kernel/test/closures/kernel_chain.dart View 1 1 chunk +0 lines, -201 lines 0 comments Download
M pkg/kernel/test/closures/suite.dart View 1 3 chunks +93 lines, -135 lines 0 comments Download
M pkg/kernel/testcases/closures/capture_closure.dart.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/testcases/closures/capture_closure_parameter.dart.expect View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/kernel/testcases/closures/closures.dart.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/testcases/closures/named_closure.dart.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/testcases/closures/non_void_context.dart.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/testcases/closures/static_tear_off.dart.expect View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/kernel/testcases/closures/type_variables.dart.expect View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Stefantsov
3 years, 8 months ago (2017-04-07 09:48:27 UTC) #2
ahe
Assuming that it is OK to import package:front_end to package:kernel as a test, perhaps you ...
3 years, 8 months ago (2017-04-07 10:15:05 UTC) #3
Dmitry Stefantsov
PTAL. Thanks for the suggestion! I removed pkg/kernel/test/closures/kernel_chain.dart and used steps and helpers from pkg/front_end/lib/src/fasta/testing/kernel_chain.dart ...
3 years, 8 months ago (2017-04-07 12:07:59 UTC) #4
ahe
lgtm
3 years, 8 months ago (2017-04-07 12:14:20 UTC) #5
Dmitry Stefantsov
3 years, 8 months ago (2017-04-07 12:21:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cd501b2db3b23a57d0fb66960b3cd4d85069cd02 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698