Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: chrome/browser/chromeos/login/screens/user_selection_screen_browsertest.cc

Issue 2808423002: cros: Show dircryto migration banner (Closed)
Patch Set: add a test, fix nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/screens/user_selection_screen.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/screens/user_selection_screen_browsertest.cc
diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen_browsertest.cc b/chrome/browser/chromeos/login/screens/user_selection_screen_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e944a25e20a56ddfd47f77e5659bfed2168bc366
--- /dev/null
+++ b/chrome/browser/chromeos/login/screens/user_selection_screen_browsertest.cc
@@ -0,0 +1,85 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <memory>
+#include <utility>
+
+#include "base/memory/ptr_util.h"
+#include "base/run_loop.h"
+#include "chrome/browser/chromeos/login/login_manager_test.h"
+#include "chrome/browser/chromeos/login/startup_utils.h"
+#include "chrome/browser/chromeos/login/test/oobe_screen_waiter.h"
+#include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
+#include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/fake_cryptohome_client.h"
+
+namespace chromeos {
+
+namespace {
+
+constexpr char kTestUser1[] = "test-user1@gmail.com";
+constexpr char kTestUser2[] = "test-user2@gmail.com";
+
+} // namespace
+
+class UserSelectionScreenTest : public LoginManagerTest {
+ public:
+ UserSelectionScreenTest()
+ : LoginManagerTest(false /* should_launch_browser */) {}
+ ~UserSelectionScreenTest() override = default;
+
+ // LoginManagerTest:
+ void SetUpInProcessBrowserTestFixture() override {
+ auto cryptohome_client = base::MakeUnique<chromeos::FakeCryptohomeClient>();
+ fake_cryptohome_client_ = cryptohome_client.get();
+ DBusThreadManager::GetSetterForTesting()->SetCryptohomeClient(
+ std::move(cryptohome_client));
+ }
+
+ FakeCryptohomeClient* fake_cryptohome_client() {
+ return fake_cryptohome_client_;
+ }
+
+ OobeUI* GetOobeUI() {
+ return static_cast<OobeUI*>(web_contents()->GetWebUI()->GetController());
+ }
+
+ private:
+ // DBusThreadManager owns this.
+ FakeCryptohomeClient* fake_cryptohome_client_ = nullptr;
+
+ DISALLOW_COPY_AND_ASSIGN(UserSelectionScreenTest);
+};
+
+IN_PROC_BROWSER_TEST_F(UserSelectionScreenTest,
+ PRE_ShowDircryptoMigrationBanner) {
+ RegisterUser(kTestUser1);
+ RegisterUser(kTestUser2);
+ StartupUtils::MarkOobeCompleted();
+}
+
+// Test that a banner shows up for users that need dircrypto migration.
+IN_PROC_BROWSER_TEST_F(UserSelectionScreenTest, ShowDircryptoMigrationBanner) {
+ // No banner for the first user since default is no migration.
+ JSExpect("!$('signin-banner').classList.contains('message-set')");
+
+ // Change the needs dircrypto migration response.
+ fake_cryptohome_client()->set_needs_dircrypto_migration(true);
+
+ // Focus to the 2nd user pod.
+ base::RunLoop pod_focus_wait_loop;
+ GetOobeUI()->signin_screen_handler()->SetFocusPODCallbackForTesting(
+ pod_focus_wait_loop.QuitClosure());
+ js_checker().Evaluate("$('pod-row').focusPod($('pod-row').pods[1])");
+ pod_focus_wait_loop.Run();
+
+ // Wait for FakeCryptohomeClient to send back the check result.
+ base::RunLoop().RunUntilIdle();
+
+ // Banner should be shown for the 2nd user.
+ JSExpect("$('signin-banner').classList.contains('message-set')");
+}
+
+} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/screens/user_selection_screen.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698