Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2808383005: Revert of Update V8 to version 5.9.212. (Closed)

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.9.212. (patchset #1 id:1 of https://codereview.chromium.org/2812203002/ ) Reason for revert: Reverting due to webkit failures in wasm tests. BUG=710824 Original issue's description: > Update V8 to version 5.9.212. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/fe9bb7e6..90043159 > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org > > Review-Url: https://codereview.chromium.org/2812203002 > Cr-Commit-Position: refs/heads/master@{#463929} > Committed: https://chromium.googlesource.com/chromium/src/+/a0831b51e5bfd4b109d80b145d9aa0f520a6636a TBR=hablich@chromium.org,kozyatinskiy@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jdoerrie
Created Revert of Update V8 to version 5.9.212.
3 years, 8 months ago (2017-04-12 13:21:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2808383005/1
3 years, 8 months ago (2017-04-12 13:21:36 UTC) #3
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
3 years, 8 months ago (2017-04-12 13:22:14 UTC) #5
Michael Hablich
3 years, 8 months ago (2017-04-12 13:37:51 UTC) #6
I am not surprised that this revert does not work as we have rolled over it. 

A follow-up roll with the fix is on the way. No need to revert anymore.

Powered by Google App Engine
This is Rietveld 408576698