arc: kArcCompatibleFilesystemChosen pref to local state and integer.

chrome/browser/chromeos/arc/arc_util.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_UTIL_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_UTIL_H_
 
 // Most utility should be put in components/arc/arc_util.{h,cc}, rather than
 // here. However, some utility implementation requires other modules defined in
 // chrome/, so this file contains such utilities.
 // Note that it is not allowed to have dependency from components/ to chrome/
 // by DEPS.
 
 class Profile;
 
 namespace base {
 class FilePath;
 }
 
 namespace arc {
 
+// Values to be stored in the local state preference to keep track of the
+// filesystem encryption migration status.
+enum FileSystemCompatibilityState {

[Luis Héctor Chávez, 2017/04/13 21:11:47]

nit: enum FileSystemCompatibilityState : int32_t

[kinaba, 2017/04/14 04:33:55]

Done.

+  // No migiration has happend, user keeps using the old file system.
+  kFileSystemIncompatible = 0,
+  // Migration has happend. New filesystem is in use.
+  kFileSystemCompatible = 1,
+  // Migration has happend, and a notification about the fact was already shown.
+  kFileSystemCompatibleAndNotified = 2,

[hidehiko, 2017/04/13 12:38:27]

This is not yet used. So how about;
- Move this definition to the CL which actually needs to use this, or
- add comment (TODO) that this will be used just in case.

[kinaba, 2017/04/14 04:33:55]

Added a TODO comment.

+};
+
 // Returns true if ARC is allowed to run for the given profile.
 // Otherwise, returns false, e.g. if the Profile is not for the primary user,
 // ARC is not available on the device, it is in the flow to set up managed
 // account creation.
 // nullptr can be safely passed to this function. In that case, returns false.
 bool IsArcAllowedForProfile(const Profile* profile);
 
 // Returns true if ARC app is allowed to show up on app list for the given
 // profile. This can be a looser condition than IsArcAllowedForProfile.
 // ARC may be temporaliry disallowed for the profile, but it may become again
@@ skipping 46 matching lines @@
 // ArcBackupRestoreEnabled and ArcLocationServiceEnabled) are managed.
 bool AreArcAllOptInPreferencesManagedForProfile(const Profile* profile);
 
 // Returns whether ARC can run on the filesystem mounted at |path|.
 // This function should run only on threads where IO operations are allowed.
 bool IsArcCompatibleFilesystem(const base::FilePath& path);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_UTIL_H_