arc: kArcCompatibleFilesystemChosen pref to local state and integer.

chrome/browser/chromeos/arc/arc_session_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/arc_session_manager.h"
 
 #include <utility>
 
 #include "ash/shelf/shelf_delegate.h"
 #include "base/bind.h"
@@ skipping 160 matching lines @@
   // Note that ArcBackupRestoreEnabled and ArcLocationServiceEnabled prefs have
   // to be off by default, until an explicit gesture from the user to enable
   // them is received. This is crucial in the cases when these prefs transition
   // from a previous managed state to the unmanaged.
   registry->RegisterBooleanPref(prefs::kArcBackupRestoreEnabled, false);
   registry->RegisterBooleanPref(prefs::kArcLocationServiceEnabled, false);
   // This is used to delete the Play user ID if ARC is disabled for an
   // AD-managed device.
   registry->RegisterStringPref(prefs::kArcActiveDirectoryPlayUserId,
                                std::string());
-  registry->RegisterBooleanPref(prefs::kArcCompatibleFilesystemChosen, false);
 }
 
 // static
+void ArcSessionManager::RegisterLocalStatePrefs(PrefRegistrySimple* registry) {
+  registry->RegisterIntegerPref(prefs::kArcCompatibleFilesystemChosen,
+                                kFileSystemIncompatible);

[xiyuan, 2017/04/13 16:35:59]

You don't need to do this for using known_user because it hosts the per-user
values under a kKnownUsers key and already registered with local state. [1]

[1]: 
https://cs.chromium.org/chromium/src/components/user_manager/known_user.cc?rc...

[kinaba, 2017/04/14 04:33:55]

Oh, I didn't know the way it works. Thanks, removed.

+}
+
+// static
 bool ArcSessionManager::IsOobeOptInActive() {
   // ARC OOBE OptIn is optional for now. Test if it exists and login host is
   // active.
   if (!user_manager::UserManager::Get()->IsCurrentUserNew())
     return false;
   if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
           chromeos::switches::kEnableArcOOBEOptIn))
     return false;
   if (!chromeos::LoginDisplayHost::default_host())
     return false;
@@ skipping 852 matching lines @@
 
 #undef MAP_STATE
 
   // Some compilers report an error even if all values of an enum-class are
   // covered exhaustively in a switch statement.
   NOTREACHED() << "Invalid value " << static_cast<int>(state);
   return os;
 }
 
 }  // namespace arc