lastchange: Remove two flags (--git-svn-go-deeper and -d/--default-lastchange) that look unused.

build/util/lastchange.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 lastchange.py -- Chromium revision fetching utility.
 """
 
 import re
@@ skipping 64 matching lines @@
     if proc.returncode == 0 and output:
       for line in reversed(output.splitlines()):
         if line.startswith('Cr-Commit-Position:'):
           pos = line.rsplit()[-1].strip()
           break
   if hash_only or not pos:
     return VersionInfo('git', hsh)
   return VersionInfo('git', '%s-%s' % (hsh, pos))
 
 
-def FetchVersionInfo(default_lastchange, directory=None,
+def FetchVersionInfo(directory=None,
                      directory_regex_prior_to_src_url='chrome|blink|svn',
-                     go_deeper=False, hash_only=False):
+                     hash_only=False):
   """
   Returns the last change (in the form of a branch, revision tuple),
   from some appropriate revision control system.
   """
   svn_url_regex = re.compile(
       r'.*/(' + directory_regex_prior_to_src_url + r')(/.*)')
 
   version_info = FetchGitRevision(directory, hash_only)
   if not version_info:
-    if default_lastchange and os.path.exists(default_lastchange):
-      revision = open(default_lastchange, 'r').read().strip()
-      version_info = VersionInfo(None, revision)
-    else:
-      version_info = VersionInfo(None, None)
+    version_info = VersionInfo(None, None)
   return version_info
 
 
 def GetHeaderGuard(path):
   """
   Returns the header #define guard for the given file path.
   This treats everything after the last instance of "src/" as being a
   relevant part of the guard. If there is no "src/", then the entire path
   is used.
   """
@@ skipping 43 matching lines @@
       return
     os.unlink(file_name)
   open(file_name, 'w').write(contents)
 
 
 def main(argv=None):
   if argv is None:
     argv = sys.argv
 
   parser = optparse.OptionParser(usage="lastchange.py [options]")
-  parser.add_option("-d", "--default-lastchange", metavar="FILE",
-                    help="Default last change input FILE.")
   parser.add_option("-m", "--version-macro",
                     help="Name of C #define when using --header. Defaults to " +
                     "LAST_CHANGE.",
                     default="LAST_CHANGE")
   parser.add_option("-o", "--output", metavar="FILE",
                     help="Write last change to FILE. " +
                     "Can be combined with --header to write both files.")
   parser.add_option("", "--header", metavar="FILE",
                     help="Write last change to FILE as a C/C++ header. " +
                     "Can be combined with --output to write both files.")
   parser.add_option("--revision-only", action='store_true',
                     help="Just print the SVN revision number. Overrides any " +
                     "file-output-related options.")
   parser.add_option("-s", "--source-dir", metavar="DIR",
                     help="Use repository in the given directory.")
-  parser.add_option("--git-svn-go-deeper", action='store_true',
-                    help="In a Git-SVN repo, dig down to the last committed " +
-                    "SVN change (historic behaviour).")
   parser.add_option("--git-hash-only", action="store_true",
                     help="In a Git repo with commit positions, report only " +
                     "the hash of the latest commit with a position.")
   opts, args = parser.parse_args(argv[1:])
 
   out_file = opts.output
   header = opts.header
 
   while len(args) and out_file is None:
     if out_file is None:
       out_file = args.pop(0)
   if args:
     sys.stderr.write('Unexpected arguments: %r\n\n' % args)
     parser.print_help()
     sys.exit(2)
 
   if opts.source_dir:
     src_dir = opts.source_dir
   else:
     src_dir = os.path.dirname(os.path.abspath(__file__))
 
-  version_info = FetchVersionInfo(opts.default_lastchange,
-                                  directory=src_dir,
-                                  go_deeper=opts.git_svn_go_deeper,
+  version_info = FetchVersionInfo(directory=src_dir,
                                   hash_only=opts.git_hash_only)
 
   if version_info.revision == None:
     version_info.revision = '0'
 
   if opts.revision_only:
     print version_info.revision
   else:
     contents = "LASTCHANGE=%s\n" % version_info.revision
     if not out_file and not opts.header:
       sys.stdout.write(contents)
     else:
       if out_file:
         WriteIfChanged(out_file, contents)
       if header:
         WriteIfChanged(header,
                        GetHeaderContents(header, opts.version_macro,
                                          version_info.revision))
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())