chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java - Issue 2808163002: [Android O] Refactor channel initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 2808163002: [Android O] Refactor channel initialization (Closed)

Patch Set: fix comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsInitializer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

index cd8e7a1453202fa7ec24cf685df32cd686c38ed2..b66d3dc3956cca8801bc99c1aa640b8bbd5ea81a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

@@ -141,13 +141,8 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {

// API level of methods you call on the builder.

// TODO(crbug.com/697104) We should probably use a Compat builder.

ChromeNotificationBuilder builder =

- NotificationBuilderFactory.createChromeNotificationBuilder(false /* preferCompat */,

- NotificationConstants.CHANNEL_ID_SITES,

- mContext.getString(

- org.chromium.chrome.R.string.notification_category_sites),

- NotificationConstants.CHANNEL_GROUP_ID_GENERAL,

- mContext.getString(

- org.chromium.chrome.R.string.notification_category_group_general));

+ NotificationBuilderFactory.createChromeNotificationBuilder(

+ false /* preferCompat */, ChannelsInitializer.CHANNEL_ID_SITES);

builder.setTicker(mTickerText);

builder.setContentIntent(mContentIntent);

builder.setDeleteIntent(mDeleteIntent);