Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3985)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2808123004: [devtools] Remove device emulation background color override. (Closed)
Patch Set: fix android tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index e906050455f400c01bd2fb676a7bf5d07f367ccb..1152b6690cee033bacbcd9a21d44fd4ce58f4b7f 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -786,7 +786,7 @@ IN_PROC_BROWSER_TEST_F(CaptureScreenshotTest,
}
// Verifies that setDefaultBackgroundColor and captureScreenshot support a
-// transparent background.
+// transparent background, and that setDeviceMetricsOverride doesn't affect it.
IN_PROC_BROWSER_TEST_F(CaptureScreenshotTest, TransparentScreenshots) {
if (base::SysInfo::IsLowEndDevice())
return;
@@ -816,6 +816,16 @@ IN_PROC_BROWSER_TEST_F(CaptureScreenshotTest, TransparentScreenshots) {
expected_bitmap.allocN32Pixels(view_size.width(), view_size.height());
expected_bitmap.eraseColor(SK_ColorTRANSPARENT);
CaptureScreenshotAndCompareTo(expected_bitmap, ENCODING_PNG, true);
+
+ // Check that device emulation does not affect the transparency.
+ params.reset(new base::DictionaryValue());
+ params->SetInteger("width", view_size.width());
+ params->SetInteger("height", view_size.height());
+ params->SetDouble("deviceScaleFactor", 0);
+ params->SetBoolean("mobile", false);
+ params->SetBoolean("fitWindow", false);
+ SendCommand("Emulation.setDeviceMetricsOverride", std::move(params));
+ CaptureScreenshotAndCompareTo(expected_bitmap, ENCODING_PNG, true);
}
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698