Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/WebKit/public/web/WebDeviceEmulationParams.h

Issue 2808123004: [devtools] Remove device emulation background color override. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebDeviceEmulationParams.h
diff --git a/third_party/WebKit/public/web/WebDeviceEmulationParams.h b/third_party/WebKit/public/web/WebDeviceEmulationParams.h
index 68b4ff7c06c8bd6bb2c872cf65c0050aaaf3a1c5..f79e1aed2548de94088447a3c724eb7ab4f08e19 100644
--- a/third_party/WebKit/public/web/WebDeviceEmulationParams.h
+++ b/third_party/WebKit/public/web/WebDeviceEmulationParams.h
@@ -50,13 +50,18 @@ struct WebDeviceEmulationParams {
// Screen orientation angle, used together with screenOrientationType.
int screen_orientation_angle;
+ // Whether to override the gutter color to a dark gray. If enabled, this will
+ // affect the rendering of pages if the page does not set a background color.
+ bool override_gutter_color;
+
WebDeviceEmulationParams()
: screen_position(kDesktop),
device_scale_factor(0),
fit_to_view(false),
scale(1),
screen_orientation_type(kWebScreenOrientationUndefined),
- screen_orientation_angle(0) {}
+ screen_orientation_angle(0),
+ override_gutter_color(true) {}
};
inline bool operator==(const WebDeviceEmulationParams& a,
@@ -67,7 +72,8 @@ inline bool operator==(const WebDeviceEmulationParams& a,
a.view_size == b.view_size && a.fit_to_view == b.fit_to_view &&
a.offset == b.offset && a.scale == b.scale &&
a.screen_orientation_type == b.screen_orientation_type &&
- a.screen_orientation_angle == b.screen_orientation_angle;
+ a.screen_orientation_angle == b.screen_orientation_angle &&
+ a.override_gutter_color == b.override_gutter_color;
}
inline bool operator!=(const WebDeviceEmulationParams& a,

Powered by Google App Engine
This is Rietveld 408576698