Fix use of generic function type aliases for fields (issue 29237)

Fix use of generic function type aliases for fields (issue 29237)

[Brian Wilkerson, 2017-04-10 21:03:04]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-04-10 21:37:17]

We need one or two new tests for parameterized generic functions used as field
types.

https://codereview.chromium.org/2808093004/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/2808093004/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/resynthesize.dart:1261: if (element is
GenericTypeAliasElementHandle) {
Per offline discussion, this is OK to close the issue for 1.23, but we want to
make it better in the bleeding edge.

https://codereview.chromium.org/2808093004/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/resynthesize.dart:1852: if ((element as
ElementHandle).actualElement
Can we put FunctionTypeAliasElementHandle into a separate variable to avoid
casting, and then if/else put into "element"?

https://codereview.chromium.org/2808093004/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/resynthesize.dart:1854: element = new
GenericTypeAliasElementHandle(
It's a bit scary that we request the actual element, so resynthesize it here.
But probably it will work fine, we create ReferenceInfo(s) lazily.

[Brian Wilkerson, 2017-04-10 22:21:20]

The new tests are uploaded.