Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2808078: Update suppression for issue 49404 and 50630. (Closed)

Created:
10 years, 4 months ago by xiyuan
Modified:
9 years, 7 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Update suppression for issue 49404 and 50630. Merged those two issues in tracker as they seem to root from the same cause. In base::Base64Encode, we have these: std::string temp; temp.resize(...); ... modp_b64_encode(&(temp[0]...); And Valgrind does not like use temp without initializing after resize. BUG=49404 TEST=Valgrind memcheck should pass.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 2 chunks +2 lines, -39 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
xiyuan
10 years, 4 months ago (2010-07-29 16:31:14 UTC) #1
xiyuan
10 years, 4 months ago (2010-08-02 17:20:53 UTC) #2
Tim's finding in crbug.com/49404 shows that the failure could be real instead of
false positive.

Closing this suppression update and investigate if a similar case could be found
for crbug.com/50630 where gfx::PNGCodec::EncodeBGRASkBitmap leaves some uninit
bytes in the buffer we passed to base::Base64Encode.

Powered by Google App Engine
This is Rietveld 408576698