Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: components/favicon/core/favicon_handler.h

Issue 2808063002: Add DownloadStatus metric to FaviconHandler (Closed)
Patch Set: Rename histogram enum descriptions Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/favicon_handler.h
diff --git a/components/favicon/core/favicon_handler.h b/components/favicon/core/favicon_handler.h
index 9e6e22b9f97126bc1762aa49db194d4225a8f635..7451e52758f01d3148fd025814fb8c0bb28f86ac 100644
--- a/components/favicon/core/favicon_handler.h
+++ b/components/favicon/core/favicon_handler.h
@@ -75,6 +75,13 @@ class FaviconService;
class FaviconHandler {
public:
+ // Outcome of a single favicon download.
pkotwicz 2017/04/10 18:30:59 Nit: Remove "single". I think that the word in unn
fhorschig 2017/04/11 12:24:53 Gone.
+ // Recorded as Favicons.DownloadOutcome and public for testing.
+ //
+ // These values must stay in sync with the FaviconDownloadStatus enum
+ // in histograms.xml.
+ enum DownloadOutcome { SUCCEEDED = 0, FAILED = 1, SKIPPED = 2 };
+
class Delegate {
public:
// Mimics WebContents::ImageDownloadCallback.
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | components/favicon/core/favicon_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698