Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: components/favicon/core/favicon_handler.h

Issue 2808063002: Add DownloadStatus metric to FaviconHandler (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_handler.h
diff --git a/components/favicon/core/favicon_handler.h b/components/favicon/core/favicon_handler.h
index 24d849e0900f8c30c39c4f6cb4eaa8bbdc538e89..30c0b1df498a75d7fa63229de28d3941d0af158e 100644
--- a/components/favicon/core/favicon_handler.h
+++ b/components/favicon/core/favicon_handler.h
@@ -75,6 +75,19 @@ class FaviconService;
class FaviconHandler {
public:
+ // Outcome of a favicon download.
+ // Recorded as Favicons.DownloadOutcome and public for testing.
+ //
+ // These values must stay in sync with the FaviconDownloadStatus enum
+ // in histograms.xml and should be treated as append-only, since it backs an
+ // UMA histogram..
+ enum class DownloadOutcome {
+ SUCCEEDED = 0,
+ FAILED = 1,
+ SKIPPED = 2,
+ DOWNLOAD_OUTCOME_COUNT = 3
+ };
+
class Delegate {
public:
// Mimics WebContents::ImageDownloadCallback.
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698