Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon/core/favicon_handler.h

Issue 2808063002: Add DownloadStatus metric to FaviconHandler (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_handler.h
diff --git a/components/favicon/core/favicon_handler.h b/components/favicon/core/favicon_handler.h
index 9e6e22b9f97126bc1762aa49db194d4225a8f635..82aa0237b75bb5a68117b71326acfa42f8472d60 100644
--- a/components/favicon/core/favicon_handler.h
+++ b/components/favicon/core/favicon_handler.h
@@ -75,6 +75,13 @@ class FaviconService;
class FaviconHandler {
public:
+ // Outcome of a single favicon download.
+ // Recorded as Favicons.DownloadOutcome and public for testing.
+ //
+ // These values must stay in sync with the FaviconCacheStatus enum
jkrcal 2017/04/10 12:29:38 nit: FaviconDownloadStatus
fhorschig 2017/04/10 13:45:37 Done.
+ // in histograms.xml.
+ enum DownloadOutcome { SUCCEEDED = 0, FAILED = 1, SKIPPED = 2 };
+
class Delegate {
public:
// Mimics WebContents::ImageDownloadCallback.
« no previous file with comments | « no previous file | components/favicon/core/favicon_handler.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698