Start wiring up modal dialog experiment in PermissionRequestManager codepath

chrome/browser/permissions/permission_dialog_delegate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PERMISSIONS_PERMISSION_DIALOG_DELEGATE_H_
 #define CHROME_BROWSER_PERMISSIONS_PERMISSION_DIALOG_DELEGATE_H_
 
 #include <memory>
 
 #include "base/android/scoped_java_ref.h"
 #include "base/callback.h"
 #include "base/macros.h"
+#include "chrome/browser/permissions/permission_prompt_android.h"
 #include "chrome/browser/permissions/permission_util.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 
 using base::android::JavaParamRef;
 using base::android::ScopedJavaLocalRef;
 
 namespace content {
 class WebContents;
 }
 
 class MediaStreamDevicesController;
 class GURL;
 class PermissionInfoBarDelegate;
 class Profile;
 class TabAndroid;
 
 // Delegate class for displaying a permission prompt as a modal dialog. Used as
 // the native to Java interface to allow Java to communicate the user's
 // decision.
 //
-// This class currently wraps a PermissionInfoBarDelegate. Future refactoring
-// will consolidate PermissionInfoBarDelegate and its subclasses together into
-// GroupedPermissionInfoBarDelegate, which will then source all of its data from
-// an underlying PermissionPromptAndroid object. At that time, this class will
-// also change to wrap a PermissionPromptAndroid.
+// This class owns a PermissionInfoBarDelegate if the PermissionRequestManager
+// is disabled and points to a PermissionPromptAndroid if it's enabled. When the
+// PermissionRequestManager is enabled by default, we can remove the code path
+// for using a PermissionInfoBarDelegate.

[raymes, 2017/04/11 02:50:35]

nit: can you add a bug link here?

[Timothy Loh, 2017/05/24 03:30:22]

Done.

+//
+// TODO(timloh): Make this a WebContentsObserver so we can remove this if the

[raymes, 2017/04/11 02:50:35]

nit: can you clarify what "this" means here

[Timothy Loh, 2017/05/24 03:30:22]

Done.

+// page navigates under us.
 class PermissionDialogDelegate {
  public:
   using PermissionSetCallback = base::Callback<void(bool, PermissionAction)>;
 
+  static void Create(content::WebContents* web_contents,
+                     PermissionPromptAndroid* permission_prompt);

[raymes, 2017/04/11 02:50:35]

nit: could you add more documentation on when each of these is used?

[Timothy Loh, 2017/05/24 03:30:22]

Done.

+
   // Creates a modal dialog for |type|.
   static void Create(content::WebContents* web_contents,
                      ContentSettingsType type,
                      const GURL& requesting_frame,
                      bool user_gesture,
                      Profile* profile,
                      const PermissionSetCallback& callback);
 
   // Creates a modal dialog for a media stream permission request.
   // TODO(dominickn): remove this when media stream requests are eventually
@@ skipping 12 matching lines @@
   void Accept(JNIEnv* env, const JavaParamRef<jobject>& obj, jboolean persist);
   void Cancel(JNIEnv* env, const JavaParamRef<jobject>& obj, jboolean persist);
   void Dismissed(JNIEnv* env, const JavaParamRef<jobject>& obj);
   void LinkClicked(JNIEnv* env, const JavaParamRef<jobject>& obj);
 
   // Frees this object and the wrapped PermissionInfoBarDelegate. Called from
   // Java once the permission dialog has been responded to.
   void Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj);
 
  private:
+  PermissionDialogDelegate(TabAndroid* tab,
+                           PermissionPromptAndroid* permission_prompt);
   PermissionDialogDelegate(
       TabAndroid* tab,
       std::unique_ptr<PermissionInfoBarDelegate> infobar_delegate_);
   ~PermissionDialogDelegate();
 
+  void Init();
+
   ScopedJavaLocalRef<jobject> CreateJavaDelegate(JNIEnv* env);
 
   TabAndroid* tab_;
 
-  // The InfoBarDelegate which this class is wrapping.
-  // TODO(dominickn,lshang) replace this with PermissionPromptAndroid as the
-  // permission prompt refactoring continues.
+  // TODO(timloh): Remove this when the refactoring is finished and we can
+  // delete the PermissionQueueController.
   std::unique_ptr<PermissionInfoBarDelegate> infobar_delegate_;
 
+  PermissionPromptAndroid* permission_prompt_;

[raymes, 2017/04/11 02:50:35]

nit: could you make a comment on the lifetime of this? When is it safe to use
this pointer?

[Timothy Loh, 2017/05/24 03:30:22]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(PermissionDialogDelegate);
 };
 
 #endif  // CHROME_BROWSER_PERMISSIONS_PERMISSION_DIALOG_DELEGATE_H_