base/values_unittest.cc - Issue 2807953002: Use base::flat_map for base::Value dictionary storage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/values_unittest.cc

Issue 2807953002: Use base::flat_map for base::Value dictionary storage. (Closed)

Patch Set: Fix swap Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/values_unittest.cc

diff --git a/base/values_unittest.cc b/base/values_unittest.cc

index 85f0a10e4e5788574ee250f9cfd648735db57023..2c7ffd6fa5feea297aca8d3fc0f02ca35fb8c25c 100644

--- a/base/values_unittest.cc

+++ b/base/values_unittest.cc

@@ -1521,8 +1521,7 @@ TEST(ValuesTest, GetWithNullOutValue) {

TEST(ValuesTest, SelfSwap) {

base::Value test(1);

- using namespace std;

- swap(test, test);

+ std::swap(test, test);

EXPECT_TRUE(test.GetInt() == 1);

}

« no previous file with comments | « base/values.cc ('k') | no next file » | no next file with comments »