Use base::flat_map for base::Value dictionary storage.

base/values.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
 
 #include <string.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 141 matching lines @@
 Value::Value(const char16* in_string) : type_(Type::STRING) {
   string_value_.Init(UTF16ToUTF8(in_string));
 }
 
 Value::Value(const string16& in_string) : type_(Type::STRING) {
   string_value_.Init(UTF16ToUTF8(in_string));
 }
 
 Value::Value(StringPiece in_string) : Value(in_string.as_string()) {}
 
+Value::Value(DictStorage&& in_dict) noexcept : type_(Type::DICTIONARY) {

[jdoerrie, 2017/04/10 11:44:57]

Same here.

+  dict_ptr_.Init(MakeUnique<DictStorage>(std::move(in_dict)));
+}
+
 Value::Value(const std::vector<char>& in_blob) : type_(Type::BINARY) {
   binary_value_.Init(in_blob);
 }
 
 Value::Value(std::vector<char>&& in_blob) noexcept : type_(Type::BINARY) {
   binary_value_.Init(std::move(in_blob));
 }
 
 Value& Value::operator=(const Value& that) {
   if (type_ == that.type_) {
@@ skipping 1165 matching lines @@
 }
 
 std::ostream& operator<<(std::ostream& out, const Value::Type& type) {
   if (static_cast<int>(type) < 0 ||
       static_cast<size_t>(type) >= arraysize(kTypeNames))
     return out << "Invalid Type (index = " << static_cast<int>(type) << ")";
   return out << Value::GetTypeName(type);
 }
 
 }  // namespace base