Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: base/BUILD.gn

Issue 2807933002: Removing (dest != prev) check from LastUnique algorithm. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/algorithm/benchmarks.cc » ('j') | base/algorithm/benchmarks.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 if (is_nacl_nonsfi) { 109 if (is_nacl_nonsfi) {
110 # TODO(phosek) bug 570839: If field_trial.cc is in a static library, 110 # TODO(phosek) bug 570839: If field_trial.cc is in a static library,
111 # nacl_helper_nonsfi doesn't link properly on Linux in debug builds. The 111 # nacl_helper_nonsfi doesn't link properly on Linux in debug builds. The
112 # reasons for this seem to involve obscure toolchain bugs. This should be 112 # reasons for this seem to involve obscure toolchain bugs. This should be
113 # fixed and this target should always be a static_library in the 113 # fixed and this target should always be a static_library in the
114 # non-component case. 114 # non-component case.
115 static_component_type = "source_set" 115 static_component_type = "source_set"
116 } 116 }
117 117
118 sources = [ 118 sources = [
119 "algorithm/sorted_ranges.h",
brettw 2017/04/26 21:48:50 Can you think of anything else we might move into
dyaroshev 2017/04/27 19:11:46 After your previous suggestion, I removed this dir
119 "allocator/allocator_check.cc", 120 "allocator/allocator_check.cc",
120 "allocator/allocator_check.h", 121 "allocator/allocator_check.h",
121 "allocator/allocator_extension.cc", 122 "allocator/allocator_extension.cc",
122 "allocator/allocator_extension.h", 123 "allocator/allocator_extension.h",
123 "allocator/allocator_interception_mac.h", 124 "allocator/allocator_interception_mac.h",
124 "allocator/allocator_interception_mac.mm", 125 "allocator/allocator_interception_mac.mm",
125 "allocator/allocator_shim.h", 126 "allocator/allocator_shim.h",
126 "allocator/malloc_zone_functions_mac.cc", 127 "allocator/malloc_zone_functions_mac.cc",
127 "allocator/malloc_zone_functions_mac.h", 128 "allocator/malloc_zone_functions_mac.h",
128 "android/animation_frame_time_histogram.cc", 129 "android/animation_frame_time_histogram.cc",
(...skipping 1757 matching lines...) Expand 10 before | Expand all | Expand 10 after
1886 configs += [ "//build/config/compiler:enable_arc" ] 1887 configs += [ "//build/config/compiler:enable_arc" ]
1887 deps = [ 1888 deps = [
1888 ":base", 1889 ":base",
1889 "//testing/gtest", 1890 "//testing/gtest",
1890 ] 1891 ]
1891 } 1892 }
1892 } 1893 }
1893 1894
1894 test("base_unittests") { 1895 test("base_unittests") {
1895 sources = [ 1896 sources = [
1897 "algorithm/sorted_ranges_unittest.cc",
1896 "allocator/allocator_interception_mac_unittest.mm", 1898 "allocator/allocator_interception_mac_unittest.mm",
1897 "allocator/malloc_zone_functions_mac_unittest.cc", 1899 "allocator/malloc_zone_functions_mac_unittest.cc",
1898 "allocator/tcmalloc_unittest.cc", 1900 "allocator/tcmalloc_unittest.cc",
1899 "android/application_status_listener_unittest.cc", 1901 "android/application_status_listener_unittest.cc",
1900 "android/content_uri_utils_unittest.cc", 1902 "android/content_uri_utils_unittest.cc",
1901 "android/jni_android_unittest.cc", 1903 "android/jni_android_unittest.cc",
1902 "android/jni_array_unittest.cc", 1904 "android/jni_array_unittest.cc",
1903 "android/jni_string_unittest.cc", 1905 "android/jni_string_unittest.cc",
1904 "android/library_loader/library_prefetcher_unittest.cc", 1906 "android/library_loader/library_prefetcher_unittest.cc",
1905 "android/path_utils_unittest.cc", 1907 "android/path_utils_unittest.cc",
(...skipping 781 matching lines...) Expand 10 before | Expand all | Expand 10 after
2687 } 2689 }
2688 2690
2689 fuzzer_test("base_json_correctness_fuzzer") { 2691 fuzzer_test("base_json_correctness_fuzzer") {
2690 sources = [ 2692 sources = [
2691 "json/correctness_fuzzer.cc", 2693 "json/correctness_fuzzer.cc",
2692 ] 2694 ]
2693 deps = [ 2695 deps = [
2694 ":base", 2696 ":base",
2695 ] 2697 ]
2696 } 2698 }
OLDNEW
« no previous file with comments | « no previous file | base/algorithm/benchmarks.cc » ('j') | base/algorithm/benchmarks.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698