third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp - Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp ('K') | « third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

index 2d0b6a791c30bf4f102efd6dff3c547112ff23a0..054da8b888f0d87d400e0815ad486231bc09ec51 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp

@@ -19,13 +19,13 @@ DisplayItem& DisplayItemList::appendByMoving(DisplayItem& item) {

#ifndef NDEBUG

String originalDebugString = item.asDebugString();

#endif

- ASSERT(item.hasValidClient());

+ DCHECK(item.hasValidClient());

DisplayItem& result =

ContiguousContainer::appendByMoving(item, item.derivedSize());

// ContiguousContainer::appendByMoving() calls an in-place constructor

// on item which replaces it with a tombstone/"dead display item" that

// can be safely destructed but should never be used.

- ASSERT(!item.hasValidClient());

+ DCHECK(!item.hasValidClient());

#ifndef NDEBUG

// Save original debug string in the old item to help debugging.

item.setClientDebugString(originalDebugString);