Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: third_party/WebKit/Source/platform/graphics/ContiguousContainer.h

Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/ContiguousContainer.h
diff --git a/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h b/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h
index 52534e297d92b127bdf2b3f6303b7dd9eca66b93..b4996edb04f6bd6778b3ba79e7f6f156dd71340a 100644
--- a/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h
+++ b/third_party/WebKit/Source/platform/graphics/ContiguousContainer.h
@@ -204,7 +204,7 @@ class ContiguousContainer : public ContiguousContainerBase {
}
void removeLast() {
- ASSERT(!isEmpty());
+ DCHECK(!isEmpty());
last().~BaseElementType();
ContiguousContainerBase::removeLast();
}
@@ -225,7 +225,7 @@ class ContiguousContainer : public ContiguousContainerBase {
// Appends a new element using memcpy, then default-constructs a base
// element in its place. Use with care.
BaseElementType& appendByMoving(BaseElementType& item, size_t size) {
- ASSERT(size >= sizeof(BaseElementType));
+ DCHECK_GE(size, sizeof(BaseElementType));
void* newItem = alignedAllocate(size);
memcpy(newItem, static_cast<void*>(&item), size);
new (&item) BaseElementType;

Powered by Google App Engine
This is Rietveld 408576698