Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp

Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics (Closed)
Patch Set: fix typo Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
index 25771014db24682c42916094374a3c966d58c419..9f08a2101fa5bfa37bd25e0cf4d46e8d7e4547f4 100644
--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
@@ -78,7 +78,7 @@ PassRefPtr<DrawingBuffer> DrawingBuffer::Create(
PreserveDrawingBuffer preserve,
WebGLVersion web_gl_version,
ChromiumImageUsage chromium_image_usage) {
- ASSERT(context_provider);
+ DCHECK(context_provider);
if (g_should_fail_drawing_buffer_creation_for_testing) {
g_should_fail_drawing_buffer_creation_for_testing = false;
@@ -91,7 +91,7 @@ PassRefPtr<DrawingBuffer> DrawingBuffer::Create(
// This might be the first time we notice that the GL context is lost.
return nullptr;
}
- ASSERT(extensions_util->SupportsExtension("GL_OES_packed_depth_stencil"));
+ DCHECK(extensions_util->SupportsExtension("GL_OES_packed_depth_stencil"));
extensions_util->EnsureExtensionEnabled("GL_OES_packed_depth_stencil");
bool multisample_supported =
want_antialiasing &&
@@ -186,7 +186,7 @@ void DrawingBuffer::SetBufferClearNeeded(bool flag) {
if (preserve_drawing_buffer_ == kDiscard) {
buffer_clear_needed_ = flag;
} else {
- ASSERT(!buffer_clear_needed_);
+ DCHECK(!buffer_clear_needed_);
}
}
@@ -270,7 +270,7 @@ bool DrawingBuffer::PrepareTextureMailboxInternal(
// 4. Here.
return false;
}
- ASSERT(!is_hidden_);
+ DCHECK(!is_hidden_);
if (!contents_changed_)
return false;
@@ -788,7 +788,7 @@ void DrawingBuffer::ClearPlatformLayer() {
}
void DrawingBuffer::BeginDestruction() {
- ASSERT(!destruction_in_progress_);
+ DCHECK(!destruction_in_progress_);
destruction_in_progress_ = true;
ClearPlatformLayer();
@@ -1051,7 +1051,7 @@ bool DrawingBuffer::PaintRenderingResultsToImageData(
WTF::ArrayBufferContents& contents) {
ScopedStateRestorer scoped_state_restorer(this);
- ASSERT(!premultiplied_alpha_);
+ DCHECK(!premultiplied_alpha_);
width = size().Width();
height = size().Height();
@@ -1120,7 +1120,7 @@ void DrawingBuffer::ReadBackFramebuffer(unsigned char* pixels,
pixels[i + 2] = std::min(255, pixels[i + 2] * pixels[i + 3] / 255);
}
} else if (op != WebGLImageConversion::kAlphaDoNothing) {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
}
}

Powered by Google App Engine
This is Rietveld 408576698