third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp - Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics (Closed)

Patch Set: rebase and fix Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp ('k') | third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

index 8f60425291892f34cd97029e6b84b83b09ffec28..97aeb4c5632b39916c654359c48be5e542d3dd4f 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

@@ -313,8 +313,8 @@ sk_sp<SkImage> DeferredImageDecoder::CreateFrameImageAtIndex(

size_t index,

bool known_to_be_opaque) {

const SkISize& decoded_size = frame_generator_->GetFullSize();

- ASSERT(decoded_size.width() > 0);

- ASSERT(decoded_size.height() > 0);

+ DCHECK_GT(decoded_size.width(), 0);

+ DCHECK_GE(decoded_size.height(), 0);

tkent 2017/04/11 22:43:25 Should be DCHECK_GT, not DCHCK_GE

Hwanseung Lee 2017/04/11 22:52:21 Done.

sk_sp<SkROBuffer> ro_buffer(rw_buffer_->newRBufferSnapshot());

RefPtr<SegmentReader> segment_reader =