Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h

Issue 2807923002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics (Closed)
Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/graphics Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ScrollDisplayItem_h 5 #ifndef ScrollDisplayItem_h
6 #define ScrollDisplayItem_h 6 #define ScrollDisplayItem_h
7 7
8 #include "platform/geometry/IntSize.h" 8 #include "platform/geometry/IntSize.h"
9 #include "platform/graphics/paint/DisplayItem.h" 9 #include "platform/graphics/paint/DisplayItem.h"
10 #include "platform/wtf/Allocator.h" 10 #include "platform/wtf/Allocator.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class PLATFORM_EXPORT BeginScrollDisplayItem final 14 class PLATFORM_EXPORT BeginScrollDisplayItem final
15 : public PairedBeginDisplayItem { 15 : public PairedBeginDisplayItem {
16 public: 16 public:
17 BeginScrollDisplayItem(const DisplayItemClient& client, 17 BeginScrollDisplayItem(const DisplayItemClient& client,
18 Type type, 18 Type type,
19 const IntSize& currentOffset) 19 const IntSize& currentOffset)
20 : PairedBeginDisplayItem(client, type, sizeof(*this)), 20 : PairedBeginDisplayItem(client, type, sizeof(*this)),
21 m_currentOffset(currentOffset) { 21 m_currentOffset(currentOffset) {
22 ASSERT(isScrollType(type)); 22 DCHECK(isScrollType(type));
23 } 23 }
24 24
25 void replay(GraphicsContext&) const override; 25 void replay(GraphicsContext&) const override;
26 void appendToWebDisplayItemList(const IntRect&, 26 void appendToWebDisplayItemList(const IntRect&,
27 WebDisplayItemList*) const override; 27 WebDisplayItemList*) const override;
28 28
29 const IntSize& currentOffset() const { return m_currentOffset; } 29 const IntSize& currentOffset() const { return m_currentOffset; }
30 30
31 private: 31 private:
32 #ifndef NDEBUG 32 #ifndef NDEBUG
33 void dumpPropertiesAsDebugString(WTF::StringBuilder&) const final; 33 void dumpPropertiesAsDebugString(WTF::StringBuilder&) const final;
34 #endif 34 #endif
35 bool equals(const DisplayItem& other) const final { 35 bool equals(const DisplayItem& other) const final {
36 return DisplayItem::equals(other) && 36 return DisplayItem::equals(other) &&
37 m_currentOffset == 37 m_currentOffset ==
38 static_cast<const BeginScrollDisplayItem&>(other) 38 static_cast<const BeginScrollDisplayItem&>(other)
39 .m_currentOffset; 39 .m_currentOffset;
40 } 40 }
41 41
42 const IntSize m_currentOffset; 42 const IntSize m_currentOffset;
43 }; 43 };
44 44
45 class PLATFORM_EXPORT EndScrollDisplayItem final : public PairedEndDisplayItem { 45 class PLATFORM_EXPORT EndScrollDisplayItem final : public PairedEndDisplayItem {
46 public: 46 public:
47 EndScrollDisplayItem(const DisplayItemClient& client, Type type) 47 EndScrollDisplayItem(const DisplayItemClient& client, Type type)
48 : PairedEndDisplayItem(client, type, sizeof(*this)) { 48 : PairedEndDisplayItem(client, type, sizeof(*this)) {
49 ASSERT(isEndScrollType(type)); 49 DCHECK(isEndScrollType(type));
50 } 50 }
51 51
52 void replay(GraphicsContext&) const override; 52 void replay(GraphicsContext&) const override;
53 void appendToWebDisplayItemList(const IntRect&, 53 void appendToWebDisplayItemList(const IntRect&,
54 WebDisplayItemList*) const override; 54 WebDisplayItemList*) const override;
55 55
56 private: 56 private:
57 #if DCHECK_IS_ON() 57 #if DCHECK_IS_ON()
58 bool isEndAndPairedWith(DisplayItem::Type otherType) const final { 58 bool isEndAndPairedWith(DisplayItem::Type otherType) const final {
59 return DisplayItem::isScrollType(otherType); 59 return DisplayItem::isScrollType(otherType);
60 } 60 }
61 #endif 61 #endif
62 }; 62 };
63 63
64 } // namespace blink 64 } // namespace blink
65 65
66 #endif // ScrollDisplayItem_h 66 #endif // ScrollDisplayItem_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698