third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp - Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

Issue 2807913002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts (Closed)

Patch Set: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/fonts Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp b/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

index 1660922e2b59db9d1ec4b5f8e5121c2f02c011d4..b3e71d7bfb7a995ee135aa60f641f72b434ec1dc 100644

--- a/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/SymbolsIteratorTest.cpp

@@ -65,7 +65,7 @@ TEST_F(SymbolsIteratorTest, Empty) {

SymbolsIterator symbolsIterator(empty.characters16(), empty.length());

unsigned limit = 0;

FontFallbackPriority symbolsFont = FontFallbackPriority::Invalid;

- ASSERT(!symbolsIterator.consume(&limit, &symbolsFont));

+ DCHECK(!symbolsIterator.consume(&limit, &symbolsFont));

ASSERT_EQ(limit, 0u);

ASSERT_EQ(symbolsFont, FontFallbackPriority::Invalid);

}