Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/win/jumplist.h

Issue 2807883002: Separate JumpListIcons delete task and update task (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/win/jumplist.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_WIN_JUMPLIST_H_ 5 #ifndef CHROME_BROWSER_WIN_JUMPLIST_H_
6 #define CHROME_BROWSER_WIN_JUMPLIST_H_ 6 #define CHROME_BROWSER_WIN_JUMPLIST_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 14 matching lines...) Expand all
25 #include "components/history/core/browser/top_sites_observer.h" 25 #include "components/history/core/browser/top_sites_observer.h"
26 #include "components/keyed_service/core/refcounted_keyed_service.h" 26 #include "components/keyed_service/core/refcounted_keyed_service.h"
27 #include "components/sessions/core/tab_restore_service.h" 27 #include "components/sessions/core/tab_restore_service.h"
28 #include "components/sessions/core/tab_restore_service_observer.h" 28 #include "components/sessions/core/tab_restore_service_observer.h"
29 #include "content/public/browser/browser_thread.h" 29 #include "content/public/browser/browser_thread.h"
30 #include "content/public/browser/notification_observer.h" 30 #include "content/public/browser/notification_observer.h"
31 #include "content/public/browser/notification_registrar.h" 31 #include "content/public/browser/notification_registrar.h"
32 32
33 namespace base { 33 namespace base {
34 class SingleThreadTaskRunner; 34 class SingleThreadTaskRunner;
35 class SequencedTaskRunner;
35 } 36 }
36 37
37 namespace chrome { 38 namespace chrome {
38 struct FaviconImageResult; 39 struct FaviconImageResult;
39 } 40 }
40 41
41 class JumpListFactory; 42 class JumpListFactory;
42 class PrefChangeRegistrar; 43 class PrefChangeRegistrar;
43 class Profile; 44 class Profile;
44 45
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 base::OneShotTimer timer_; 180 base::OneShotTimer timer_;
180 181
181 // Holds data that can be accessed from multiple threads. 182 // Holds data that can be accessed from multiple threads.
182 scoped_refptr<base::RefCountedData<JumpListData>> jumplist_data_; 183 scoped_refptr<base::RefCountedData<JumpListData>> jumplist_data_;
183 184
184 // Id of last favicon task. It's used to cancel current task if a new one 185 // Id of last favicon task. It's used to cancel current task if a new one
185 // comes in before it finishes. 186 // comes in before it finishes.
186 base::CancelableTaskTracker::TaskId task_id_; 187 base::CancelableTaskTracker::TaskId task_id_;
187 188
188 // A task runner running tasks to update the jumplist in JumpListIcons and to 189 // A task runner running tasks to update the jumplist in JumpListIcons and to
189 // delete JumpListIconsOld sequentially. 190 // delete JumpListIconsOld sequentially.
gab 2017/04/10 19:33:12 Update comment.
chengx 2017/04/10 21:09:14 Done.
190 scoped_refptr<base::SingleThreadTaskRunner> single_thread_task_runner_; 191 scoped_refptr<base::SingleThreadTaskRunner> single_thread_task_runner_;
gab 2017/04/10 19:33:12 Make these variable names specific now that they'r
chengx 2017/04/10 21:09:14 Done.
191 192
193 // A task runner which runs the background JumpListIconsOld deletion tasks.
194 scoped_refptr<base::SequencedTaskRunner> sequenced_task_runner_;
195
192 // For callbacks may be run after destruction. 196 // For callbacks may be run after destruction.
193 base::WeakPtrFactory<JumpList> weak_ptr_factory_; 197 base::WeakPtrFactory<JumpList> weak_ptr_factory_;
194 198
195 DISALLOW_COPY_AND_ASSIGN(JumpList); 199 DISALLOW_COPY_AND_ASSIGN(JumpList);
196 }; 200 };
197 201
198 #endif // CHROME_BROWSER_WIN_JUMPLIST_H_ 202 #endif // CHROME_BROWSER_WIN_JUMPLIST_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/win/jumplist.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698