ios/chrome/browser/tabs/BUILD.gn - Issue 2807843002: Refactor creation of SadTabView into a tab helper object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/BUILD.gn

Issue 2807843002: Refactor creation of SadTabView into a tab helper object (Closed)

Patch Set: Change to delegate interface and other misc review changes. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/BUILD.gn

diff --git a/ios/chrome/browser/tabs/BUILD.gn b/ios/chrome/browser/tabs/BUILD.gn

index c3292843ef02ba2c4866f6cf55de7b41261624b9..d11875dc0e506fde82c30f2aac2e3ab0d64b963e 100644

--- a/ios/chrome/browser/tabs/BUILD.gn

+++ b/ios/chrome/browser/tabs/BUILD.gn

@@ -21,6 +21,7 @@ source_set("tabs") {

"//components/sessions",

"//components/signin/ios/browser",

"//components/sync_sessions",

+ "//ios/chrome/browser/web:sad_tab_tab_helper_delegate",

"//ios/net",

"//ios/web",

"//ui/base",

@@ -97,6 +98,7 @@ source_set("tabs_internal") {

"//ios/chrome/browser/ui/toolbar",

"//ios/chrome/browser/ui/util",

"//ios/chrome/browser/web",

+ "//ios/chrome/browser/web:sad_tab_tab_helper_delegate",

"//ios/chrome/browser/web:web_internal",

"//ios/net",

"//ios/public/provider/chrome/browser",

« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.h » ('j') | ios/chrome/browser/web/sad_tab_tab_helper.h » ('J')