ios/chrome/browser/ui/sad_tab/sad_tab_view.h - Issue 2807843002: Refactor creation of SadTabView into a tab helper object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/sad_tab/sad_tab_view.h

Issue 2807843002: Refactor creation of SadTabView into a tab helper object (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/sad_tab/sad_tab_view.h

diff --git a/ios/chrome/browser/ui/sad_tab/sad_tab_view.h b/ios/chrome/browser/ui/sad_tab/sad_tab_view.h

index 1607cf1269b5255f5316dee793f6726d923328ec..8c7b471a70a46dbc034a6a77f568a702b5847730 100644

--- a/ios/chrome/browser/ui/sad_tab/sad_tab_view.h

+++ b/ios/chrome/browser/ui/sad_tab/sad_tab_view.h

@@ -9,6 +9,10 @@

#include "base/ios/block_types.h"

+#if !defined(__has_feature) || !__has_feature(objc_arc)

pkl (ping after 24h if needed) 2017/04/11 00:09:21 Should this ARC boilerplate be in the .h file?

PL 2017/04/11 01:35:21 Done: Think I was just overzealous here, thanks!

+#error "This file requires ARC support."

+#endif

// The view used to show "sad tab" content to the user when WKWebView's renderer

// process crashes.

@interface SadTabView : UIView