ios/chrome/browser/web/sad_tab_tab_helper_delegate.h - Issue 2807843002: Refactor creation of SadTabView into a tab helper object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/web/sad_tab_tab_helper_delegate.h

Issue 2807843002: Refactor creation of SadTabView into a tab helper object (Closed)

Patch Set: Minor review changes Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/chrome/browser/web/sad_tab_tab_helper.mm ('K') | « ios/chrome/browser/web/sad_tab_tab_helper.mm ('k') | ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm » ('j') | ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef tab_helper_delegate_h
	sdefresne 2017/04/11 08:17:39 This is not using the correct header guards. Pleas This is not using the correct header guards. Please use src/tools/boilerplate.py script to create file with the correct header guards. peterlaurens 2017/04/11 21:57:27 Done! Thanks! Show quoted text On 2017/04/11 08:17:39, sdefresne wrote: > This is not using the correct header guards. Please use src/tools/boilerplate.py > script to create file with the correct header guards. Done! Thanks!
	6 #define tab_helper_delegate_h

	7

	8 #import <Foundation/Foundation.h>

	9

	10 NS_ASSUME_NONNULL_BEGIN

	11

	12 class SadTabTabHelper;

	13

	14 // SadTabTabHelperDelegate defines an interface that allows SadTabTabHelper

	15 // instances to learn about the visibility of the Tab they are helping.

	16 @protocol SadTabTabHelperDelegate<NSObject>

	17

	18 // Returns whether the tab for the tab helper is visible, allowing differences
	Eugene But (OOO till 7-30) 2017/04/11 15:17:00 Do you want to elaborate what \|visible\| means in t Do you want to elaborate what \|visible\| means in this context (app is in active state and tab is the frontmost)? peterlaurens 2017/04/11 21:57:27 Done! Show quoted text On 2017/04/11 15:17:00, Eugene But wrote: > Do you want to elaborate what \|visible\| means in this context (app is in active > state and tab is the frontmost)? Done!
	19 // in the behavior of the helper for visible vs. non-visible tabs.

	20 - (BOOL)isTabVisibleForTabHelper:(SadTabTabHelper*)tabHelper;

	21

	22 @end

	23

	24 NS_ASSUME_NONNULL_END

	25

	26 #endif /* tab_helper_delegate_h */

OLD	NEW