Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: ios/chrome/browser/tabs/tab_helper_util.mm

Issue 2807843002: Refactor creation of SadTabView into a tab helper object (Closed)
Patch Set: Attempt to fix build dependency Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/ui/sad_tab/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/tabs/tab_helper_util.h" 5 #import "ios/chrome/browser/tabs/tab_helper_util.h"
6 6
7 #if !defined(__has_feature) || !__has_feature(objc_arc) 7 #if !defined(__has_feature) || !__has_feature(objc_arc)
8 #error "This file requires ARC support." 8 #error "This file requires ARC support."
9 #endif 9 #endif
10 10
(...skipping 15 matching lines...) Expand all
26 #import "ios/chrome/browser/signin/account_consistency_service_factory.h" 26 #import "ios/chrome/browser/signin/account_consistency_service_factory.h"
27 #import "ios/chrome/browser/ssl/ios_security_state_tab_helper.h" 27 #import "ios/chrome/browser/ssl/ios_security_state_tab_helper.h"
28 #import "ios/chrome/browser/store_kit/store_kit_tab_helper.h" 28 #import "ios/chrome/browser/store_kit/store_kit_tab_helper.h"
29 #import "ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.h" 29 #import "ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.h"
30 #import "ios/chrome/browser/tabs/legacy_tab_helper.h" 30 #import "ios/chrome/browser/tabs/legacy_tab_helper.h"
31 #import "ios/chrome/browser/tabs/tab.h" 31 #import "ios/chrome/browser/tabs/tab.h"
32 #import "ios/chrome/browser/translate/chrome_ios_translate_client.h" 32 #import "ios/chrome/browser/translate/chrome_ios_translate_client.h"
33 #import "ios/chrome/browser/web/blocked_popup_tab_helper.h" 33 #import "ios/chrome/browser/web/blocked_popup_tab_helper.h"
34 #import "ios/chrome/browser/web/network_activity_indicator_tab_helper.h" 34 #import "ios/chrome/browser/web/network_activity_indicator_tab_helper.h"
35 #import "ios/chrome/browser/web/repost_form_tab_helper.h" 35 #import "ios/chrome/browser/web/repost_form_tab_helper.h"
36 #import "ios/chrome/browser/web/sad_tab_tab_helper.h"
36 #import "ios/public/provider/chrome/browser/chrome_browser_provider.h" 37 #import "ios/public/provider/chrome/browser/chrome_browser_provider.h"
37 #import "ios/web/public/web_state/web_state.h" 38 #import "ios/web/public/web_state/web_state.h"
38 39
39 void AttachTabHelpers(web::WebState* web_state) { 40 void AttachTabHelpers(web::WebState* web_state) {
40 Tab* tab = LegacyTabHelper::GetTabForWebState(web_state); 41 Tab* tab = LegacyTabHelper::GetTabForWebState(web_state);
41 42
42 ios::ChromeBrowserState* browser_state = 43 ios::ChromeBrowserState* browser_state =
43 ios::ChromeBrowserState::FromBrowserState(web_state->GetBrowserState()); 44 ios::ChromeBrowserState::FromBrowserState(web_state->GetBrowserState());
44 45
45 // IOSChromeSessionTabHelper comes first because it sets up the tab ID, 46 // IOSChromeSessionTabHelper comes first because it sets up the tab ID,
46 // and other helpers may rely on that. 47 // and other helpers may rely on that.
47 IOSChromeSessionTabHelper::CreateForWebState(web_state); 48 IOSChromeSessionTabHelper::CreateForWebState(web_state);
48 49
49 NetworkActivityIndicatorTabHelper::CreateForWebState(web_state, tab.tabId); 50 NetworkActivityIndicatorTabHelper::CreateForWebState(web_state, tab.tabId);
50 IOSChromeSyncedTabDelegate::CreateForWebState(web_state); 51 IOSChromeSyncedTabDelegate::CreateForWebState(web_state);
51 InfoBarManagerImpl::CreateForWebState(web_state); 52 InfoBarManagerImpl::CreateForWebState(web_state);
52 IOSSecurityStateTabHelper::CreateForWebState(web_state); 53 IOSSecurityStateTabHelper::CreateForWebState(web_state);
53 RepostFormTabHelper::CreateForWebState(web_state); 54 RepostFormTabHelper::CreateForWebState(web_state);
54 BlockedPopupTabHelper::CreateForWebState(web_state); 55 BlockedPopupTabHelper::CreateForWebState(web_state);
55 FindTabHelper::CreateForWebState(web_state, tab.findInPageControllerDelegate); 56 FindTabHelper::CreateForWebState(web_state, tab.findInPageControllerDelegate);
56 StoreKitTabHelper::CreateForWebState(web_state); 57 StoreKitTabHelper::CreateForWebState(web_state);
58 SadTabTabHelper::CreateForWebState(web_state, tab);
57 59
58 ReadingListModel* model = 60 ReadingListModel* model =
59 ReadingListModelFactory::GetForBrowserState(browser_state); 61 ReadingListModelFactory::GetForBrowserState(browser_state);
60 ReadingListWebStateObserver::FromWebState(web_state, model); 62 ReadingListWebStateObserver::FromWebState(web_state, model);
61 63
62 if (AccountConsistencyService* account_consistency_service = 64 if (AccountConsistencyService* account_consistency_service =
63 ios::AccountConsistencyServiceFactory::GetForBrowserState( 65 ios::AccountConsistencyServiceFactory::GetForBrowserState(
64 browser_state)) { 66 browser_state)) {
65 account_consistency_service->SetWebStateHandler(web_state, tab); 67 account_consistency_service->SetWebStateHandler(web_state, tab);
66 } 68 }
67 ChromeIOSTranslateClient::CreateForWebState(web_state); 69 ChromeIOSTranslateClient::CreateForWebState(web_state);
68 70
69 ios::ChromeBrowserState* original_browser_state = 71 ios::ChromeBrowserState* original_browser_state =
70 browser_state->GetOriginalChromeBrowserState(); 72 browser_state->GetOriginalChromeBrowserState();
71 favicon::WebFaviconDriver::CreateForWebState( 73 favicon::WebFaviconDriver::CreateForWebState(
72 web_state, 74 web_state,
73 ios::FaviconServiceFactory::GetForBrowserState( 75 ios::FaviconServiceFactory::GetForBrowserState(
74 original_browser_state, ServiceAccessType::IMPLICIT_ACCESS), 76 original_browser_state, ServiceAccessType::IMPLICIT_ACCESS),
75 ios::HistoryServiceFactory::GetForBrowserState( 77 ios::HistoryServiceFactory::GetForBrowserState(
76 original_browser_state, ServiceAccessType::IMPLICIT_ACCESS), 78 original_browser_state, ServiceAccessType::IMPLICIT_ACCESS),
77 ios::BookmarkModelFactory::GetForBrowserState(original_browser_state)); 79 ios::BookmarkModelFactory::GetForBrowserState(original_browser_state));
78 history::WebStateTopSitesObserver::CreateForWebState( 80 history::WebStateTopSitesObserver::CreateForWebState(
79 web_state, 81 web_state,
80 ios::TopSitesFactory::GetForBrowserState(original_browser_state).get()); 82 ios::TopSitesFactory::GetForBrowserState(original_browser_state).get());
81 83
82 // Allow the embedder to attach tab helpers. 84 // Allow the embedder to attach tab helpers.
83 ios::GetChromeBrowserProvider()->AttachTabHelpers(web_state, tab); 85 ios::GetChromeBrowserProvider()->AttachTabHelpers(web_state, tab);
84 } 86 }
OLDNEW
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/ui/sad_tab/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698