Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: ash/system/virtual_keyboard/virtual_keyboard_tray.cc

Issue 2807693002: Make LogoutButtonTray a regular View (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/virtual_keyboard/virtual_keyboard_tray.cc
diff --git a/ash/system/virtual_keyboard/virtual_keyboard_tray.cc b/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
index f953e2415d90c0a065b4a1c3b22ae7978db7e4ed..7dd3599a8a399b39f0a1eb649963fbdd57eeb17d 100644
--- a/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
+++ b/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
@@ -13,6 +13,7 @@
#include "ash/shell.h"
#include "ash/strings/grit/ash_strings.h"
#include "ash/system/tray/tray_constants.h"
+#include "ash/system/tray/tray_container.h"
#include "ash/wm_window.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/display/display.h"
@@ -25,13 +26,18 @@
namespace ash {
VirtualKeyboardTray::VirtualKeyboardTray(WmShelf* wm_shelf)
- : TrayBackgroundView(wm_shelf, true),
+ : TrayBackgroundView(wm_shelf),
icon_(new views::ImageView),
wm_shelf_(wm_shelf) {
SetInkDropMode(InkDropMode::ON);
- icon_->SetImage(gfx::CreateVectorIcon(kShelfKeyboardIcon, kShelfIconColor));
- SetIconBorderForShelfAlignment();
+ gfx::ImageSkia image =
+ gfx::CreateVectorIcon(kShelfKeyboardIcon, kShelfIconColor);
+ icon_->SetImage(image);
+ const int vertical_padding = (kTrayItemSize - image.height()) / 2;
+ const int horizontal_padding = (kTrayItemSize - image.width()) / 2;
+ icon_->SetBorder(views::CreateEmptyBorder(
+ gfx::Insets(vertical_padding, horizontal_padding)));
tray_container()->AddChildView(icon_);
// The Shell may not exist in some unit tests.
@@ -49,14 +55,6 @@ VirtualKeyboardTray::~VirtualKeyboardTray() {
Shell::Get()->keyboard_ui()->RemoveObserver(this);
}
-void VirtualKeyboardTray::SetShelfAlignment(ShelfAlignment alignment) {
- if (alignment == shelf_alignment())
- return;
-
- TrayBackgroundView::SetShelfAlignment(alignment);
- SetIconBorderForShelfAlignment();
-}
-
base::string16 VirtualKeyboardTray::GetAccessibleNameForTray() {
return l10n_util::GetStringUTF16(
IDS_ASH_VIRTUAL_KEYBOARD_TRAY_ACCESSIBLE_NAME);
@@ -99,14 +97,6 @@ void VirtualKeyboardTray::OnKeyboardBoundsChanging(
void VirtualKeyboardTray::OnKeyboardClosed() {}
-void VirtualKeyboardTray::SetIconBorderForShelfAlignment() {
- const gfx::ImageSkia& image = icon_->GetImage();
- const int vertical_padding = (kTrayItemSize - image.height()) / 2;
- const int horizontal_padding = (kTrayItemSize - image.width()) / 2;
- icon_->SetBorder(views::CreateEmptyBorder(
- gfx::Insets(vertical_padding, horizontal_padding)));
-}
-
void VirtualKeyboardTray::ObserveKeyboardController() {
keyboard::KeyboardController* keyboard_controller =
keyboard::KeyboardController::GetInstance();
« no previous file with comments | « ash/system/virtual_keyboard/virtual_keyboard_tray.h ('k') | ash/system/web_notification/web_notification_tray.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698