Move Work From CompositorFrameSinkSupport() To Init()

cc/surfaces/compositor_frame_sink_support.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_SURFACES_COMPOSITOR_FRAME_SINK_SUPPORT_H_
 #define CC_SURFACES_COMPOSITOR_FRAME_SINK_SUPPORT_H_
 
 #include <memory>
 #include <unordered_set>
 #include <vector>
@@ skipping 19 matching lines @@
  public:
   CompositorFrameSinkSupport(CompositorFrameSinkSupportClient* client,
                              SurfaceManager* surface_manager,
                              const FrameSinkId& frame_sink_id,
                              bool is_root,
                              bool handles_frame_sink_id_invalidation,
                              bool needs_sync_points);
 
   ~CompositorFrameSinkSupport() override;
 
+  void Init();

[boliu, 2017/04/10 17:02:23]

it's usually better to have a public factory method that calls Init, and make
the constructor private. does that work here?

[Alex Z., 2017/04/10 17:34:29]

We're still in discussion about the necessity of the Init since
SurfaceFactory and SurfaceFactoryClient are soon to be removed.

I will get back to you on the factory method when that's settled.

+
   const FrameSinkId& frame_sink_id() const { return frame_sink_id_; }
 
   Surface* current_surface_for_testing() {
     return surface_factory_.current_surface_for_testing();
   }
 
   const ReferencedSurfaceTracker& ReferenceTrackerForTesting() const {
     return reference_tracker_;
   }
 
@@ skipping 79 matching lines @@
   const bool handles_frame_sink_id_invalidation_;
 
   base::WeakPtrFactory<CompositorFrameSinkSupport> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(CompositorFrameSinkSupport);
 };
 
 }  // namespace cc
 
 #endif  // CC_SURFACES_COMPOSITOR_FRAME_SINK_SUPPORT_H_